Operators do not honour the Rx observable contract for terminal events

Aperta
  • Qualcosa non va?
#1,142 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
csharp
Ambito
backend

Direzione di ricerca

The issue describes a harness covering 476 observable-taking extension methods, but does not name its files or the two child issues containing the findings. Start by locating those child issues and the harness, then inspect the grouped operator implementations and their overloads. Verify completion and error behavior for every affected overload; the Switch cases are already handled by #1137 and #1139.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Switch turned out to be dropping OnCompleted and mishandling OnError (#1136, #1138). That raised an obvious question: how many other operators do the same thing?

I wrote a harness that drives every operator overload with a source that completes or errors, and records what the operator actually emits. It covered 476 of the 499 extension methods that take an IObservable. The remainder do not return an observable, so there is nothing to assert.

106 overloads across 33 operator names either never deliver OnCompleted, or get the error path wrong by throwing out of Subscribe, converting the error to a completion, or dropping it entirely.

The findings are split by collection type in the two child issues. Several of the entries are the same bug reached by different names, so both lists are grouped by the implementation the overloads share rather than by public API name.

Worth noting for anyone picking this up: overloads of the same operator often do not share behaviour. Sort(comparer) completes correctly while Sort(observableComparer) and Sort(comparer, resorter) do not. Fixes need checking against every overload, not one representative.

The Switch entries in both lists are already handled by #1137 and #1139 and are only there for completeness.

Lingua principale
C#
Stelle
1.9k
Fork
194
Merge medio
12m
PR unite (30g)
1

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di reactivemarbles/DynamicData

Tutte le issue di reactivemarbles/DynamicData

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.