[Android] With enableFabricCommitBranching, a commit hook's clone in the React revision merge drops the raw props the view is created from
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 22/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- android, cpp, react-native
- 领域
- mobile-dev
调研方向
Start from ShadowNode::propsForClonedShadowNode and Props::initializeDynamicProps to see why the source's raw props are dropped once hasBeenMounted_ is set, then follow FabricUIManager's merge callback and FabricMountingManager::getProps. Use the linked reproducer's NativePropsWriter.cpp and its commit=ReactRevisionMerge logcat lines to confirm the clone loses nativeID and backgroundColor. Done means the merge commit creates the view with React's original raw props, so the red box renders with commit branching enabled.
由索引模型根据 Issue 内容生成。
描述
Description
On Android with enableFabricCommitBranching on, a view created by React's commit can mount without the props React gave it. That happens whenever a commit hook clones the node in the merge of React's revision: a background colour, nativeID, testID and everything else React set are missing from the view.
React's commit lands on its branch and runs updateMountedFlag, which marks each node it created as mounted (hasBeenMounted_), although no revision holding those nodes has mounted yet. The merge mounts them later, in FabricUIManager's frame callback. Commit hooks run again in that merge commit (ShadowTreeCommitSource::ReactRevisionMerge). A hook that clones a node passing only the props it writes, as Reanimated's ShadowTreeCloner and the animation backend's commit hook do, gets props whose raw props hold only those props: Props::initializeDynamicProps keeps the raw props of its own parse, and ShadowNode::propsForClonedShadowNode merges the source's raw props in only while the source has not been mounted. The merge then creates the view from those raw props, since FabricMountingManager::getProps sends rawProps at the default flags.
With the flag off, the same hook clones the node in the commit that creates it, before updateMountedFlag, so propsForClonedShadowNode keeps React's raw props and the view mounts complete.
Steps to reproduce
- Clone https://github.com/YevheniiKotyrlo/react-native-merge-clone-raw-props and install:
cd ReproducerApp && yarn install. It is the reproducer template on[email protected], with@react-native-community/[email protected]. - Build and install it with commit branching on:
cd android && ./gradlew assembleRelease -PreactNativeArchitectures=arm64-v8a, thenadb install -r app/build/outputs/apk/release/app-release.apk. - Launch the app. It installs a C++ commit hook (
ReproducerApp/android/app/src/main/jni/NativePropsWriter.cpp) that writesopacity: 1onto every node whosenativeIDstarts withwritten-, then renders a red 200 × 200 view withnativeIDandtestIDwritten-box. - Read
adb logcat -s PropsWriter, which logs each clone the hook makes, and look at the screen. - Repeat steps 2 to 4 with
-PcommitBranching=falseadded to the Gradle command.
Expected (what step 5 shows): the red box shows.
Actual with the flag on: no box shows. The hook's clone in React's commit keeps the node's raw props; its clone in the merge (commit=ReactRevisionMerge) holds neither nativeID nor backgroundColor, and the merge creates the view from it, so the view has no background colour and none of the props React set. With the flag off, the view is created in React's own commit from the clone that kept them; the later clones there drop them too, but by then the view exists, and an update only applies what changed.
React Native Version
0.89.0-nightly-20261030-4afc5d5b9
Affected Platforms
Runtime - Android, Build - Windows
Output of npx @react-native-community/cli info
System:
OS: Windows 11 10.0.26300
CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor "
Memory: 148.06 GB / 255.67 GB
Binaries:
Node:
version: 26.12.1
path: C:\Program Files\nodejs\node.EXE
Yarn:
version: 1.22.22
path: C:\Users\yevhe.YEVHENII\AppData\Roaming\npm\yarn.CMD
npm:
version: 12.2.1
path: C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
API Levels:
- "33"
- "35"
- "35"
- "35"
- "36"
- "37"
- "37"
Build Tools:
- 35.0.0
- 36.0.0
- 36.1.0
- 37.0.0
System Images:
- android-26 | Google APIs Intel x86_64 Atom
- android-28 | Google APIs Intel x86_64 Atom
- android-29 | Google APIs Intel x86_64 Atom
- android-30 | Google APIs Intel x86_64 Atom
- android-31 | Google APIs Intel x86_64 Atom
- android-32 | Google APIs Intel x86_64 Atom
- android-33 | Google APIs Intel x86_64 Atom
- android-34 | Google APIs Intel x86_64 Atom
- android-35 | Google APIs Intel x86_64 Atom
- android-36.1 | Google Play Intel x86_64 Atom
- android-36.1 | Pre-Release 16 KB Page Size Google Play Intel x86_64 Atom
- android-37.0 | Google APIs Intel x86_64 Atom
Android NDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: AI-262.9437.185.2621.16467767
Visual Studio: Not Found
Languages:
Java:
version: 17.0.20.1
path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
Ruby: Not Found
npmPackages:
"@react-native-community/cli":
installed: 21.0.0-alpha.1
wanted: 21.0.0-alpha.1
react:
installed: 19.3.0
wanted: 19.3.0
react-native:
installed: 0.89.0-nightly-20261030-4afc5d5b9
wanted: 0.89.0-nightly-20261030-4afc5d5b9
react-native-windows: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
Stacktrace or Logs
With enableFabricCommitBranching (adb logcat -s PropsWriter):
PropsWriter: commit=React tag=10 source rawProps: nativeID=yes backgroundColor=yes; written rawProps: nativeID=yes backgroundColor=yes
PropsWriter: commit=ReactRevisionMerge tag=10 source rawProps: nativeID=yes backgroundColor=yes; written rawProps: nativeID=no backgroundColor=no
PropsWriter: commit=Unknown tag=10 source rawProps: nativeID=no backgroundColor=no; written rawProps: nativeID=no backgroundColor=no
With -PcommitBranching=false:
PropsWriter: commit=React tag=10 source rawProps: nativeID=yes backgroundColor=yes; written rawProps: nativeID=yes backgroundColor=yes
PropsWriter: commit=Unknown tag=10 source rawProps: nativeID=yes backgroundColor=yes; written rawProps: nativeID=no backgroundColor=no
PropsWriter: commit=Unknown tag=10 source rawProps: nativeID=no backgroundColor=no; written rawProps: nativeID=no backgroundColor=no
MANDATORY Reproducer
https://github.com/YevheniiKotyrlo/react-native-merge-clone-raw-props
Screenshots and Videos
RedMagic NX809J, Android 16, release builds of the reproducer:
-PcommitBranching=false |
enableFabricCommitBranching on |
|---|---|
![]() |
![]() |
- 主要语言
- C++
- 星标
- 127k
- 派生
- 25.4k
- 平均合并
- 2 天 9 小时
- 30 天内合并 PR
- 91
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
react/react-native 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
react/react-native#59722 ·
维护者通常 2 天内回复
-
Android: new WebSocket() crashes the app for a URL that OkHttp or java.net.URI rejects可能已有人在做 @sorinc03 今天认领。 未关闭🌐Networking Needs: Author Feedback Needs: Repro Platform: Android
难度 2/5 1-3 小时 新手友好度 72/100
react/react-native#59704 · 1 条评论 ·
维护者通常 2 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
react/react-native#59694 ·
维护者通常 2 天内回复
-
Android autolinking keeps a stale autolinking.json when only bun.lock changes, since bun.lock isn't in the default lockFiles可能已有人在做 @lazerg 于 3 天前认领。 未关闭
难度 1/5 1 小时以内 新手友好度 85/100
react/react-native#59693 ·
维护者通常 2 天内回复
-
Image.resolveAssetSource's TypeScript declaration drops the null it returns for an unknown asset可能已有人在做 @Hassan1305 于 3 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
react/react-native#59648 · 1 条评论 ·
维护者通常 2 天内回复
查看 react/react-native 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 80/100
-
难度 2/5 1-3 小时 新手友好度 72/100
eclipse-score/lifecycle#929 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
colbymchenry/codegraph#3223 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
firefox-devtools/profiler#6436 · 1 条评论 ·
维护者通常 1 天内回复

