zipfile honors inconsistent compression method state when extracting

未关闭
  • 哪里不对？
#161,945 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
security

调研方向

Start from the reproduction script in the issue, which rewrites only the local header compression method and then reads the member through zipfile. The fix belongs in the zipfile module's code that reads local file headers and checks them against central directory entries, where the existing file-name mismatch check is the pattern to follow. Done means zipfile rejects an entry whose local and central compression methods differ, and a regression test covers it. The body links PR gh-161948, so check that work before starting.

由索引模型根据 Issue 内容生成。

描述

type-bug
Bug report

Moving from GHSA to public after discussion consensus.

Summary

An user can contrive a ZIP input such that Python's zipfile attempts to decompress a member of the file with a different decompression method than other parsers will select. This can result in an extraction differential.

Details

ZIP entries record their compression method in two places: the local header and the central directory.

Python honors the central directory entry's compression method, even if it differs from the local file entry's stated method. Consequently, Python will attempt to decompress an entry with an inconsistent method.

The correct behavior is to reject the discrepancy, similarly to how Python already rejects file name discrepancies between the local header and central directory.

PoC

import binascii
import io
import struct
import zipfile

original = b"central-directory interpretation\n" * 4

# Produce a valid DEFLATED archive and close it so the central directory exists.
buf = io.BytesIO()
with zipfile.ZipFile(buf, "w", compression=zipfile.ZIP_DEFLATED) as z:
    z.writestr("test.txt", original)

raw = bytearray(buf.getvalue())

with zipfile.ZipFile(io.BytesIO(raw), "r") as z:
    info = z.getinfo("test.txt")

local = info.header_offset
assert raw[local : local + 4] == b"PK\x03\x04"

name_len, extra_len = struct.unpack_from("<HH", raw, local + 26)
data_start = local + 30 + name_len + extra_len
compressed = bytes(raw[data_start : data_start + info.compress_size])

# Rewrite ONLY the local header to describe a valid STORED member.
#
# Local-header offsets:
#   +8:  compression method (uint16)
#   +14: CRC-32             (uint32)
#   +18: compressed size    (uint32)
#   +22: uncompressed size  (uint32)
struct.pack_into("<H", raw, local + 8, zipfile.ZIP_STORED)
struct.pack_into(
    "<III",
    raw,
    local + 14,
    binascii.crc32(compressed) & 0xFFFFFFFF,
    len(compressed),
    len(compressed),
)

central = raw.index(b"PK\x01\x02")
local_method = struct.unpack_from("<H", raw, local + 8)[0]
central_method = struct.unpack_from("<H", raw, central + 10)[0]

assert local_method == zipfile.ZIP_STORED
assert central_method == zipfile.ZIP_DEFLATED

print(f"local={local_method}, central={central_method}")

# Python trusts the central directory and successfully decompresses.
with zipfile.ZipFile(io.BytesIO(raw), "r") as z:
    python_contents = z.read("test.txt")

assert python_contents == original
print("zipfile:", repr(python_contents))

# Simulate a parser that trusts the local header.
local_crc, local_csize, local_usize = struct.unpack_from("<III", raw, local + 14)
local_contents = bytes(raw[data_start : data_start + local_csize])

assert len(local_contents) == local_usize
assert binascii.crc32(local_contents) & 0xFFFFFFFF == local_crc
assert local_contents != python_contents

print("local-header parser:", repr(local_contents))
print("different outputs:", local_contents != python_contents)

Impact

The impact is a fail-open differential: zipfile extracts the malformed ZIP as though it's valid. Other parsers may pick the other incorrect fail-open half of the differential, which is to extract using the local file entry's compression method.

A strict parser should reject a ZIP file if it contains a local file entry/central directory entry pair that has an inconsistent compression method.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux, Windows, macOS

Linked PRs
  • gh-161948
主要语言
Python
星标
78.2k
派生
36.6k
平均合并
19 小时 57 分钟
30 天内合并 PR
630

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

python/cpython 的其他 Issue

查看 python/cpython 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。