FeatureSet cleanup: simplify over-complex type-system remnants in compatibility_hints.py
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 45/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- python
调研方向
Start with docs/design/TODO_COMPATIBILITY_HINTS.md and review the listed methods in caldav/compatibility_hints.py. The issue also calls for migrating old_flags in about 12 server config dictionaries, so identify those locations and check how their features are represented before changing them. Done means the listed cleanup and migration are complete, with the shim removed where no longer needed.
由索引模型根据 Issue 内容生成。
描述
⚠️ This comment is AI-generated (Claude Sonnet 4.6 via Claude Code) on behalf of tobixen
The FeatureSet class in caldav/compatibility_hints.py was written with a more ambitious vision than what ended up being needed. A review of all its methods found several items that can be simplified or removed. Details are documented in docs/design/TODO_COMPATIBILITY_HINTS.md.
Summary of findings
1. Dead/buggy bool branch in _convert_node
The else branch for non-server-feature types has inverted logic (not node.get('enable') returns True when enable=False) and is unreachable in practice — no caller uses is_supported(bool) on client-feature or server-peculiarity features. Should be replaced with an AssertionError to surface accidental misuse.
2. Possibly redundant _derive_from_subfeatures call in is_supported
For features with no dots, the method is called twice in the same lookup path (once in the loop body, once in the post-loop block). Needs careful review to confirm if one call is truly redundant.
3. _old_flags migration (ongoing)
Already marked ## TODO: remove this when it can be removed. ~12 server config dicts still carry old_flags lists. Each needs to be translated into new-style dotted features, then the shim code can be deleted.
4. feature_tree / _dots_to_tree can be simplified
Builds and caches a full nested-dict tree only to answer one-level subfeature lookups in find_feature. Can be replaced with a one-liner list comprehension, eliminating both methods.
5. _collapse_key carries vestigial enable/observed fields
These slots exist for the complex type vision but collapse is only ever called on server-feature nodes. Simplify to just return feature_dict.get('support').
6. copyFeatureSet should be renamed copy_feature_set
Inconsistent camelCase already noted with a TODO comment. No external callers; safe rename.
Suggested order
- Items 3 and 6 are independent and safe to do first.
- Items 1, 2, 4, 5 are interrelated around the type-system simplification and are best tackled together.
⚠️ This comment is AI-generated (Claude Sonnet 4.6 via Claude Code) on behalf of tobixen
- 主要语言
- Python
- 星标
- 412
- 派生
- 113
- 平均合并
- 1 天 2 小时
- 30 天内合并 PR
- 41
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
python-caldav/caldav 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
python-caldav/caldav#687 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 25/100
python-caldav/caldav#774 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 25/100
python-caldav/caldav#769 ·
维护者通常 1 天内回复
-
难度 3/5 半天 新手友好度 50/100
python-caldav/caldav#765 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
python-caldav/caldav#763 ·
维护者通常 1 天内回复
查看 python-caldav/caldav 的全部 Issue
相似的 Issue
-
fix formatting of the sample database page of the docs可能已有人在做 @Aaqibhafeezkhan 今天认领。 未关闭documentation good first issue help wanted
难度 1/5 1 小时以内 新手友好度 72/100
chaoss/CollectOSS#544 · 1 条评论 ·
维护者通常 1 天内回复
-
area/plugin good first issue
难度 2/5 1-3 小时 新手友好度 85/100
kestra-io/plugin-soda#137 ·
-
难度 2/5 半天 新手友好度 62/100
ibm-granite/granite.build#504 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 62/100
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复