Apply vcal.fix() fixups on save, not only on load
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start from CalendarObjectResource._set_data and vcal.fix() to see where fixups run on load, then trace the save path that sends the icalendar data to the server unchanged. The open questions are which fixups are safe to apply on save and how this interacts with sending given bytes unchanged (issue 763). Done means fixups run on save without breaking byte passthrough, with the warning behaviour settled.
由索引模型根据 Issue 内容生成。
描述
Disclaimer: AI-generated text below the line, generated by Claude Opus 5.5, from the prompt:
Cleanup on save is not something going into 3.5.0. Fix the message to point this out, but also file an issue so that we can do fixups on save later.
vcal.fix() only runs when raw icalendar data is set on an object (CalendarObjectResource._set_data, on load). Data built or edited through the icalendar instance and then saved goes to the server as-is.
A concrete case: reading component.categories on a component without categories makes the icalendar library insert an empty CATEGORIES: (https://github.com/collective/icalendar/issues/1722). If the object is saved after that, the empty line is stored on the server. The fixup added for it in vcal.fix() (https://github.com/python-caldav/caldav/pull/773, for 3.5.0) only drops it the next time the object is loaded.
Running the fixups on save as well would stop such breakage from reaching the server. Things to consider:
- Which fixups are safe to apply on the way out.
- It interacts with https://github.com/python-caldav/caldav/issues/763: sending given bytes unchanged must stay possible.
- The fixup warning is logged on every modification, so it would also fire on save.
- 主要语言
- Python
- 星标
- 412
- 派生
- 113
- 平均合并
- 1 天 2 小时
- 30 天内合并 PR
- 41
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
python-caldav/caldav 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
python-caldav/caldav#687 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 25/100
python-caldav/caldav#769 ·
维护者通常 1 天内回复
-
难度 3/5 半天 新手友好度 50/100
python-caldav/caldav#765 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
python-caldav/caldav#763 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 25/100
python-caldav/caldav#761 ·
维护者通常 1 天内回复
查看 python-caldav/caldav 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 74/100
aws-samples/sample-per-model-bedrock#243 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
FuRongJun-1999/dsh-memory#404 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
bug frontend
难度 2/5 1-3 小时 新手友好度 68/100
PennyLaneAI/catalyst#3337 ·
维护者通常 1 天内回复
-
Workflow.schedule stops when a cron deadline passes before sleep可能已有人在做 @HuaTNA 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复