[Bug]: Codex text generation fails with "invalid transport" when launch args define an MCP server

未关闭
  • 哪里不对？
#36,210 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
半天
新手友好度
58/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
shell, typescript
领域
backend

调研方向

Start in apps/server/src/textGeneration/CodexTextGeneration.ts, where codexMcpServersOff builds the inline mcp_servers={...} override and codexExecLaunchArgs supplies the earlier -c flags. The issue's shell snippets reproduce the override conflict with the plain Codex CLI, so run them first. Done means text generation succeeds with a launch-arg MCP server present and that server is disabled for the run. Server names containing a dot need the table form kept, so account for that case.

由索引模型根据 Issue 内容生成。

描述

Before submitting
  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.
Area

apps/server

Steps to reproduce
  1. Give a Codex provider instance launch args that define an MCP server with -c flags, for example: 
    -c 'mcp_servers.t3-code.url="http://127.0.0.1:1/mcp"' -c 'mcp_servers.t3-code.enabled_tools=["t3_thread_list"]'
  2. Use that instance for text generation.
  3. Start a new thread in a worktree.

The cause reproduces with plain Codex CLI, without T3:

A=(-c 'mcp_servers.t3-code.url="http://127.0.0.1:1/mcp"')
codex "${A[@]}" -c 'mcp_servers={"t3-code"={enabled=false}}' mcp list --json   # invalid transport in `mcp_servers.t3-code`
codex "${A[@]}" -c 'mcp_servers.t3-code.enabled=false'        mcp list --json   # works: enabled=false, transport kept
codex -c 'mcp_servers={"t3-code"={enabled=false}}' "${A[@]}"  mcp list --json   # works: table first, launch args merge into it
Expected behavior

The thread gets a generated title and the worktree branch is renamed, with the launch-arg MCP server turned off for the text-generation run like any other server.

Actual behavior

Every text-generation run fails before Codex starts, so threads keep no generated title and branches keep their t3/xxxxxxxx name:

Could not rename the worktree branch, so it stays t3/cbad53ab. Text generation failed in generateBranchName:
Codex CLI command failed: Error loading config.toml: invalid transport
in `mcp_servers.t3-code`

generateThreadTitle fails with the same error.

Cause. In apps/server/src/textGeneration/CodexTextGeneration.ts, codexMcpServersOff turns the listed servers off with one inline table:

`mcp_servers={${names.map((name) => `${JSON.stringify(name)}={enabled=false}`).join(",")}}`

Since #32597, the launch args' -c flags also reach codex exec through codexExecLaunchArgs, ahead of this table. Within Codex's CLI override layer, the later mcp_servers={...} replaces the mcp_servers table that the earlier -c mcp_servers.t3-code.* flags built. That leaves t3-code = {enabled=false} with no transport. Servers defined in config.toml are unaffected, because the CLI layer merges with the file layer.

A quoted dotted path, -c 'mcp_servers."t3-code".enabled=false', also failed, with invalid transport in mcp_servers."t3-code", so Codex does not seem to read quoted segments in -c keys.

Suggested change. Emit one --config mcp_servers.<name>.enabled=false per server instead of one table, because a dotted override merges with whatever earlier flags defined. Server names that contain a . cannot be written that way. Those could keep the table form, placed before codexExecLaunchArgs(launchArgs) so that the launch args merge into it instead of being replaced.

Impact

Major degradation or frequent failure

Version or commit

0.1.10-nightly.20261113.4616

Environment

Linux (WSL2), Codex CLI 0.169.0-alpha.6

Logs or stack traces
TextGenerationError: Text generation failed in generateThreadTitle: Codex CLI command failed: Error loading config.toml: invalid transport
in `mcp_servers.t3-code`
    at runCodexJson.runCodexCommand (.../t3:355300:20)
Workaround

A wrapper set as the provider's binary path that rewrites the mcp_servers={"NAME"={enabled=false},...} argument into one mcp_servers.NAME.enabled=false flag per server, in the same position.

主要语言
TypeScript
星标
24.8k
派生
6.4k
平均合并
59 分钟
30 天内合并 PR
418

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

pingdotgg/t3code 的其他 Issue

查看 pingdotgg/t3code 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。