[Bug]: Codex text generation fails with "invalid transport" when launch args define an MCP server

Aperta
  • Qualcosa non va?
#36,210 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
58/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
shell, typescript
Ambito
backend

Direzione di ricerca

Start in apps/server/src/textGeneration/CodexTextGeneration.ts, where codexMcpServersOff builds the inline mcp_servers={...} override and codexExecLaunchArgs supplies the earlier -c flags. The issue's shell snippets reproduce the override conflict with the plain Codex CLI, so run them first. Done means text generation succeeds with a launch-arg MCP server present and that server is disabled for the run. Server names containing a dot need the table form kept, so account for that case.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Before submitting
  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.
Area

apps/server

Steps to reproduce
  1. Give a Codex provider instance launch args that define an MCP server with -c flags, for example: 
    -c 'mcp_servers.t3-code.url="http://127.0.0.1:1/mcp"' -c 'mcp_servers.t3-code.enabled_tools=["t3_thread_list"]'
  2. Use that instance for text generation.
  3. Start a new thread in a worktree.

The cause reproduces with plain Codex CLI, without T3:

A=(-c 'mcp_servers.t3-code.url="http://127.0.0.1:1/mcp"')
codex "${A[@]}" -c 'mcp_servers={"t3-code"={enabled=false}}' mcp list --json   # invalid transport in `mcp_servers.t3-code`
codex "${A[@]}" -c 'mcp_servers.t3-code.enabled=false'        mcp list --json   # works: enabled=false, transport kept
codex -c 'mcp_servers={"t3-code"={enabled=false}}' "${A[@]}"  mcp list --json   # works: table first, launch args merge into it
Expected behavior

The thread gets a generated title and the worktree branch is renamed, with the launch-arg MCP server turned off for the text-generation run like any other server.

Actual behavior

Every text-generation run fails before Codex starts, so threads keep no generated title and branches keep their t3/xxxxxxxx name:

Could not rename the worktree branch, so it stays t3/cbad53ab. Text generation failed in generateBranchName:
Codex CLI command failed: Error loading config.toml: invalid transport
in `mcp_servers.t3-code`

generateThreadTitle fails with the same error.

Cause. In apps/server/src/textGeneration/CodexTextGeneration.ts, codexMcpServersOff turns the listed servers off with one inline table:

`mcp_servers={${names.map((name) => `${JSON.stringify(name)}={enabled=false}`).join(",")}}`

Since #32597, the launch args' -c flags also reach codex exec through codexExecLaunchArgs, ahead of this table. Within Codex's CLI override layer, the later mcp_servers={...} replaces the mcp_servers table that the earlier -c mcp_servers.t3-code.* flags built. That leaves t3-code = {enabled=false} with no transport. Servers defined in config.toml are unaffected, because the CLI layer merges with the file layer.

A quoted dotted path, -c 'mcp_servers."t3-code".enabled=false', also failed, with invalid transport in mcp_servers."t3-code", so Codex does not seem to read quoted segments in -c keys.

Suggested change. Emit one --config mcp_servers.<name>.enabled=false per server instead of one table, because a dotted override merges with whatever earlier flags defined. Server names that contain a . cannot be written that way. Those could keep the table form, placed before codexExecLaunchArgs(launchArgs) so that the launch args merge into it instead of being replaced.

Impact

Major degradation or frequent failure

Version or commit

0.1.10-nightly.20261113.4616

Environment

Linux (WSL2), Codex CLI 0.169.0-alpha.6

Logs or stack traces
TextGenerationError: Text generation failed in generateThreadTitle: Codex CLI command failed: Error loading config.toml: invalid transport
in `mcp_servers.t3-code`
    at runCodexJson.runCodexCommand (.../t3:355300:20)
Workaround

A wrapper set as the provider's binary path that rewrites the mcp_servers={"NAME"={enabled=false},...} argument into one mcp_servers.NAME.enabled=false flag per server, in the same position.

Lingua principale
TypeScript
Stelle
24.8k
Fork
6.4k
Merge medio
59m
PR unite (30g)
418

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di pingdotgg/t3code

Tutte le issue di pingdotgg/t3code

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.