Enable log redaction by default in TiFlash Server and Proxy

未关闭
#11,160 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
15/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
停滞
技术栈
cpp
领域
backend, databases

调研方向

Read the coordinated implementation PRs, TiFlash #11158 and tidb-engine-ext #460, and inspect the Server and Learner/Proxy security defaults, configuration samples, and client-c mode propagation they change. The issue reports successful focused tests and cluster validation; the full integration CI retry stopped at an external Rust mirror timeout. Done means both defaults and samples agree, explicit modes are preserved, client-c receives the correct mode, and relevant tests pass.

由索引模型根据 Issue 内容生成。

描述

affects-8.5 component/storage type/enhancement

Enhancement

Enable log redaction by default in both TiFlash Server and TiFlash Learner/Proxy, so deployments that omit the redaction options do not print supported user-data values by default.

Current defaults:

  • Server: security.redact_info_log = false.
  • Learner/Proxy: security.redact-info-log = false.

Expected behavior:

  • Default both configuration options to true, including missing security sections and missing options.
  • Preserve explicit false/"off" and "marker" configurations.
  • Keep configuration samples consistent with the defaults.
  • Correct mode propagation to client-c, which currently falls through to marker mode.

Implementation:

Validation results (2026-10-27):

  • Build actual native ARM64 TiFlash (41ce1aca2e) and Proxy (4246ca1) from the two PRs.
  • Start a complete local cluster: 1 PD + 1 TiKV + 1 TiDB + 1 modified TiFlash/Proxy.
  • Omit both redaction options in active configs; confirm runtime Proxy configuration reports redact-info-log: true.
  • TiFlash replica becomes available (availability/progress 1); forced query returns the expected row with an mpp[tiflash] plan.
  • Actual Server runtime probes: default hides the key, explicit false preserves the raw key, marker wraps it.
  • Actual corrected region_merge_common_handle.test: passed in 43.046 seconds.
  • Local Proxy configuration tests: 10 passed; local Security unit tests: 2 passed.
  • Actual local native C++ GoogleTests: 10 passed, 0 failed (3 RedactLogTest + 7 TiFlashSecurityTest).
  • Shut down all task-owned test clusters/mock servers cleanly and retain built binaries and logs.

The latest full integration CI retry stopped before tests because the external Rust mirror rsproxy.cn returned HTTP 504. The focused local tests and modified-component cluster startup/query validation above completed successfully.

The two PRs are coordinated changes; the Proxy code is maintained in the separate tidb-engine-ext repository.

主要语言
C++
星标
1k
派生
428
平均合并
2 天 7 小时
30 天内合并 PR
100

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

pingcap/tiflash 的其他 Issue

查看 pingcap/tiflash 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。