Enable log redaction by default in TiFlash Server and Proxy

Abierto
#11,160 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
15/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
cpp

Línea de trabajo

Read the coordinated implementation PRs, TiFlash #11158 and tidb-engine-ext #460, and inspect the Server and Learner/Proxy security defaults, configuration samples, and client-c mode propagation they change. The issue reports successful focused tests and cluster validation; the full integration CI retry stopped at an external Rust mirror timeout. Done means both defaults and samples agree, explicit modes are preserved, client-c receives the correct mode, and relevant tests pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

affects-8.5 component/storage type/enhancement

Enhancement

Enable log redaction by default in both TiFlash Server and TiFlash Learner/Proxy, so deployments that omit the redaction options do not print supported user-data values by default.

Current defaults:

  • Server: security.redact_info_log = false.
  • Learner/Proxy: security.redact-info-log = false.

Expected behavior:

  • Default both configuration options to true, including missing security sections and missing options.
  • Preserve explicit false/"off" and "marker" configurations.
  • Keep configuration samples consistent with the defaults.
  • Correct mode propagation to client-c, which currently falls through to marker mode.

Implementation:

Validation results (2026-10-27):

  • Build actual native ARM64 TiFlash (41ce1aca2e) and Proxy (4246ca1) from the two PRs.
  • Start a complete local cluster: 1 PD + 1 TiKV + 1 TiDB + 1 modified TiFlash/Proxy.
  • Omit both redaction options in active configs; confirm runtime Proxy configuration reports redact-info-log: true.
  • TiFlash replica becomes available (availability/progress 1); forced query returns the expected row with an mpp[tiflash] plan.
  • Actual Server runtime probes: default hides the key, explicit false preserves the raw key, marker wraps it.
  • Actual corrected region_merge_common_handle.test: passed in 43.046 seconds.
  • Local Proxy configuration tests: 10 passed; local Security unit tests: 2 passed.
  • Actual local native C++ GoogleTests: 10 passed, 0 failed (3 RedactLogTest + 7 TiFlashSecurityTest).
  • Shut down all task-owned test clusters/mock servers cleanly and retain built binaries and logs.

The latest full integration CI retry stopped before tests because the external Rust mirror rsproxy.cn returned HTTP 504. The focused local tests and modified-component cluster startup/query validation above completed successfully.

The two PRs are coordinated changes; the Proxy code is maintained in the separate tidb-engine-ext repository.

Lenguaje dominante
C++
Estrellas
1k
Forks
428
Merge medio
2 d 7 h
PR fusionados (30 d)
100

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pingcap/tiflash

Todos los issues de pingcap/tiflash

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.