Missing zend_return_unwrap_ref() calls trigger assertion failures:

未关闭
  • 哪里不对？
#25,404 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
c, php
领域
backend, testing-qa

调研方向

Start by reading the linked issue #20628 and tracing the listed reproductions through RecursiveIteratorIterator::callHasChildren(), callGetChildren(), RecursiveFilterIterator::hasChildren(), and zend_call_method() in zend_test. Find where returned references need unwrapping, then add regression coverage for the reproductions and verify the assertion failures are gone.

由索引模型根据 Issue 内容生成。

描述

Bug Extension: standard Extension: zend_test Status: Verified

The following cases trigger assertion failures, tested on latest 8.6 dev (0dbc4a7953a8aca38d0cf04fa4fb4ac076f00419)

php: Zend/zend_vm_execute.h:2167: const zend_op *ZEND_DO_FCALL_SPEC_RETVAL_USED_HANDLER(zend_execute_data *, const zend_op *): Assertion `((call->func->common.fn_flags & (1 << 12)) && !zend_return_should_unwrap_ref(call)) ? (zval_get_type(&(*(ret))) == 10) : !(zval_get_type(&(*(ret))) == 10)' failed.
Aborted (core dumped)
`RecursiveIteratorIterator::callHasChildren()` 
<?php

class Demo implements RecursiveIterator {

	public bool $v = true;

	public function getChildren(): ?RecursiveIterator { return null; }
	public function &hasChildren(): bool { return $this->v; }

	public function current(): mixed { return null; }
	public function key(): mixed { return null; }
	public function next(): void {}
	public function rewind(): void {}
	public function valid(): bool { return true; }

}

$r = new RecursiveIteratorIterator(new Demo());
var_dump($r->callHasChildren());
`RecursiveIteratorIterator::callGetChildren()` 
<?php

class Demo implements RecursiveIterator {

	public mixed $v = null;

	public function &getChildren(): ?RecursiveIterator { return $this->v; }
	public function hasChildren(): bool { return true; }

	public function current(): mixed { return null; }
	public function key(): mixed { return null; }
	public function next(): void {}
	public function rewind(): void {}
	public function valid(): bool { return true; }

}

$r = new RecursiveIteratorIterator(new Demo());
var_dump($r->callGetChildren());
`RecursiveFilterIterator::hasChildren()` 
<?php

class ConcreteRecursiveFilterIterator extends RecursiveFilterIterator {

	public function accept(): bool { return true; }

}

class Demo implements RecursiveIterator {

	public bool $v = true;

	public function getChildren(): ?RecursiveIterator { return null; }
	public function &hasChildren(): bool { return $this->v; }

	public function current(): mixed { return null; }
	public function key(): mixed { return null; }
	public function next(): void {}
	public function rewind(): void {}
	public function valid(): bool { return true; }

}

$r = new ConcreteRecursiveFilterIterator(new Demo());
var_dump($r->hasChildren());
`zend_call_method()` from zend_test 
<?php

class Demo {
	public mixed $v = true;
	public function &returnsRef() { return $this->v; }
}

$d = new Demo();
var_dump(zend_call_method($d, 'returnsRef'));

Cross-link #20628

主要语言
C
星标
41.8k
派生
8.5k
平均合并
2 天 13 小时
30 天内合并 PR
145

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

php/php-src 的其他 Issue

查看 php/php-src 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。