Tearsheet: Escape should only close the active topmost layer
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 68/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- typescript
- 领域
- frontend
调研方向
Start from the Tearsheet and modal components that handle Escape-key events, then reproduce the nested-modal and stacked-Tearsheet cases described in the issue. Trace which layer receives the event and inspect existing tests around modal dismissal; done means Escape closes only the active topmost layer while underlying layers remain open.
由索引模型根据 Issue 内容生成。
描述
Problem
When a Tearsheet opens another modal, such as a file-selection modal, pressing
Escape closes both the modal and the underlying Tearsheet.
This suggests that the Escape-key event is being handled by multiple layers rather
than only by the active topmost layer. With stacked Tearsheets, the same behavior
could dismiss multiple workflow levels with a single keypress and unexpectedly
discard in-progress work.
Steps to reproduce
-
Open a Tearsheet.
-
Open a modal or file-selection flow from within the Tearsheet.
-
Press
Escape. -
Observe that both the nested modal and the underlying Tearsheet close.
-
Repeat with multiple stacked Tearsheets and verify whether one
Escapedismisses more than the active layer.
Here I hit escape to cancel out of the modal but all views are closed:
Expected behavior
Pressing Escape should dismiss only the active topmost modal or Tearsheet.
Underlying layers should remain open, and the event should not continue to
trigger their close handlers.
Context
This was observed in
odh-dashboard#9589.
The follow-up discussion is
here.
Related stacked-modal accessibility work:
Jira Issue: PF-4706
- 主要语言
- TypeScript
- 星标
- 10
- 派生
- 40
- 平均合并
- 23 小时 23 分钟
- 30 天内合并 PR
- 2
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
patternfly/react-component-groups 的其他 Issue
-
SkeletonTable: add option to hide header skeleton rows可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
patternfly/react-component-groups#968 · 1 条评论 ·
-
难度 3/5 1-2 天 新手友好度 72/100
-
Tearsheet layout updates: Masthead coverage and inset token alignment可能已有人在做 @GAUNSD 于 6 天前认领。 未关闭PF Team
难度 4/5 3-5 天 新手友好度 48/100
patternfly/react-component-groups#985 · 1 条评论 · 已指派 1 人 ·
-
Pull in Modal animation support for Tearsheets可能已有人在做 @thatblindgeye 于 20 天前认领。 未关闭PF Team
patternfly/react-component-groups#979 · 已指派 1 人 ·
-
MissingPage: support multiple action buttons可能已有人在做 @platex-rehor-bot 于 41 天前认领。 未关闭
难度 3/5 1-2 天 新手友好度 68/100
查看 patternfly/react-component-groups 的全部 Issue
相似的 Issue
-
难度 2/5 1 小时以内 新手友好度 85/100
capricorn86/happy-dom#2474 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
JSerwatka/letterboxd-tweaks#81 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
siyuan-note/siyuan#20165 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 90/100
polkadot-js/phishing#5716 ·
-
bug
难度 2/5 1-3 小时 新手友好度 90/100
juice-shop/juice-shop#3662 ·
维护者通常 1 天内回复