Restore Tab/Shift+Tab focus-exit test coverage
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- playwright, typescript
- 领域
- accessibility, testing
调研方向
Start with elements/pf-v5-accordion/test/pf-accordion.spec.ts and elements/pf-v5-search-input/test/pf-search-input.spec.ts, reviewing the existing keyboard-navigation tests and the four removed or weakened assertions. Run the relevant test files, then restore coverage for focus leaving each component through Tab or Shift+Tab using one of the listed approaches. Done means all four focus-exit cases are asserted again.
由索引模型根据 Issue 内容生成。
描述
Context
PR #3121 migrated unit tests from Playwright to Puppeteer. Puppeteer cannot move focus outside the browser viewport via Tab/Shift+Tab, so four assertions that verified focus leaving a component were removed or weakened.
Removed/weakened assertions
- Accordion: Shift+Tab from first header exits accordion - removed entirely (no prior focusable element to land on)
- Accordion: Shift+Tab from last header exits accordion - removed entirely
- Accordion: Tab out then Shift+Tab back returns to panel link - removed the Shift+Tab return portion
- Search-input: Tab from expanded listbox defocuses combobox - changed from asserting nothing is focused to asserting listbox is closed
What to restore
All four cases test that focus leaves the component entirely via Tab/Shift+Tab. Options:
- Add Playwright e2e tests (
*.e2e.ts) for these keyboard navigation flows, since e2e tests still run on Playwright - Investigate whether Puppeteer's
page.bringToFront()or CDPInput.dispatchKeyEventwith proper target can simulate Tab-out behavior - Use a sentinel focusable element before/after the component in the test fixture to catch focus without needing to leave the page
Files affected
elements/pf-v5-accordion/test/pf-accordion.spec.tselements/pf-v5-search-input/test/pf-search-input.spec.ts
- 主要语言
- TypeScript
- 星标
- 394
- 派生
- 107
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
patternfly/patternfly-elements 的其他 Issue
-
bug
patternfly/patternfly-elements#3158 · 已指派 1 人 ·
-
patternfly/patternfly-elements#3136 · 1 条评论 · 已指派 1 人 ·
-
docs
patternfly/patternfly-elements#3131 · 已指派 1 人 ·
-
难度 5/5 一周以上 新手友好度 38/100
patternfly/patternfly-elements#3118 ·
-
难度 5/5 一周以上 新手友好度 25/100
patternfly/patternfly-elements#3110 ·
查看 patternfly/patternfly-elements 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 75/100
-
bug v2
难度 2/5 1-3 小时 新手友好度 75/100
modelcontextprotocol/inspector#2458 · 1 条评论 ·
-
难度 1/5 1 小时以内 新手友好度 75/100
railmapgen/rmp-gallery#4068 ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
难度 2/5 1-3 小时 新手友好度 70/100
carbon-design-system/ibm-products#9907 ·