Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Restore Tab/Shift+Tab focus-exit test coverage

未关闭
#3,122 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
playwright, typescript

调研方向

Start with elements/pf-v5-accordion/test/pf-accordion.spec.ts and elements/pf-v5-search-input/test/pf-search-input.spec.ts, reviewing the existing keyboard-navigation tests and the four removed or weakened assertions. Run the relevant test files, then restore coverage for focus leaving each component through Tab or Shift+Tab using one of the listed approaches. Done means all four focus-exit cases are asserted again.

由索引模型根据 Issue 内容生成。

描述

Context

PR #3121 migrated unit tests from Playwright to Puppeteer. Puppeteer cannot move focus outside the browser viewport via Tab/Shift+Tab, so four assertions that verified focus leaving a component were removed or weakened.

Removed/weakened assertions

  1. Accordion: Shift+Tab from first header exits accordion - removed entirely (no prior focusable element to land on)
  2. Accordion: Shift+Tab from last header exits accordion - removed entirely
  3. Accordion: Tab out then Shift+Tab back returns to panel link - removed the Shift+Tab return portion
  4. Search-input: Tab from expanded listbox defocuses combobox - changed from asserting nothing is focused to asserting listbox is closed

What to restore

All four cases test that focus leaves the component entirely via Tab/Shift+Tab. Options:

  • Add Playwright e2e tests (*.e2e.ts) for these keyboard navigation flows, since e2e tests still run on Playwright
  • Investigate whether Puppeteer's page.bringToFront() or CDP Input.dispatchKeyEvent with proper target can simulate Tab-out behavior
  • Use a sentinel focusable element before/after the component in the test fixture to catch focus without needing to leave the page

Files affected

  • elements/pf-v5-accordion/test/pf-accordion.spec.ts
  • elements/pf-v5-search-input/test/pf-search-input.spec.ts
主要语言
TypeScript
星标
394
派生
107
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

patternfly/patternfly-elements 的其他 Issue

查看 patternfly/patternfly-elements 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。