Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Restore Tab/Shift+Tab focus-exit test coverage

Abierto
#3,122 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
playwright, typescript
Área
accessibility, testing

Línea de trabajo

Start with elements/pf-v5-accordion/test/pf-accordion.spec.ts and elements/pf-v5-search-input/test/pf-search-input.spec.ts, reviewing the existing keyboard-navigation tests and the four removed or weakened assertions. Run the relevant test files, then restore coverage for focus leaving each component through Tab or Shift+Tab using one of the listed approaches. Done means all four focus-exit cases are asserted again.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Context

PR #3121 migrated unit tests from Playwright to Puppeteer. Puppeteer cannot move focus outside the browser viewport via Tab/Shift+Tab, so four assertions that verified focus leaving a component were removed or weakened.

Removed/weakened assertions

  1. Accordion: Shift+Tab from first header exits accordion - removed entirely (no prior focusable element to land on)
  2. Accordion: Shift+Tab from last header exits accordion - removed entirely
  3. Accordion: Tab out then Shift+Tab back returns to panel link - removed the Shift+Tab return portion
  4. Search-input: Tab from expanded listbox defocuses combobox - changed from asserting nothing is focused to asserting listbox is closed

What to restore

All four cases test that focus leaves the component entirely via Tab/Shift+Tab. Options:

  • Add Playwright e2e tests (*.e2e.ts) for these keyboard navigation flows, since e2e tests still run on Playwright
  • Investigate whether Puppeteer's page.bringToFront() or CDP Input.dispatchKeyEvent with proper target can simulate Tab-out behavior
  • Use a sentinel focusable element before/after the component in the test fixture to catch focus without needing to leave the page

Files affected

  • elements/pf-v5-accordion/test/pf-accordion.spec.ts
  • elements/pf-v5-search-input/test/pf-search-input.spec.ts
Lenguaje dominante
TypeScript
Estrellas
394
Forks
107
Sin PR fusionados en 30 d

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de patternfly/patternfly-elements

Todos los issues de patternfly/patternfly-elements

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.