Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

[feat]: Update `<pf-v6-modal>` for PatternFly v6

未关闭
#3,022 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
冷清
技术栈
html, typescript

调研方向

Start with .claude/ADVICE.md and inspect elements/pf-v5-modal/ before planning the replacement. Check elements/package.json, eslint.config.js, _snippets/, and framework-integration/ for references to update. Done means a PatternFly v6 modal with the requested API, demos, public API and a11y tests, review checks, changeset, and a PR targeting staging/pfv6.

由索引模型根据 Issue 内容生成。

描述

1:1 for dev priority: medium

Summary

Update `` to implement the PatternFly v6 Modal component.

Dialog overlay for focused tasks, confirmations, or information display. Supports size variants and custom footers.

Prior Art

Source Element Status
PFE v4 `` Exists
cem `` Exists
cockpit `` Exists
chickadee `` Exists

Notes

  • Should use the native `` element internally
  • Use `popover` attribute where appropriate for light-dismiss behavior

Requirements

  • MUST implement PFv6 visual designs
  • MUST provide end-user feature parity with `@patternfly/react-core` Modal
  • MAY adjust element API to leverage web platform strengths
  • SHOULD maintain CSS custom property theming compatibility
  • SHOULD expose useful CSS shadow parts

Element-specific considerations

  • React `variant`: `small`, `medium`, `large`, `xlarge`, `default` - map to `size` attribute
  • React `isScrollable` - scrollable body with sticky header/footer; map to `scrollable` attribute
  • React `title`, `titleIconVariant` (`success`, `danger`, `warning`, `info`, `custom`) - use slot or attribute
  • React `actions` - footer button group; use `slot="footer"`
  • React `description` - subtitle below title
  • React `hasNoBodyWrapper` - removes the default `ModalBoxBody` padding wrapper
  • React `disableFocusTrap` - should almost never be needed; do not expose unless truly necessary
  • Native `` handles: focus trap, Escape key close, backdrop (`::backdrop` pseudo-element)
  • Light-dismiss (click outside): use `dialog.addEventListener("click", ...)` pattern on backdrop
  • `showModal()` vs `show()` vs `popover`: use `showModal()` for proper modal semantics (blocks interaction)
  • Expose `open` property/attribute for declarative open/close

Checklist

Rename
  • Delete `elements/pf-v5-modal/`
  • Update `elements/package.json` exports
  • Update `eslint.config.js` ignore globs if applicable
  • Update docs `_snippets/` and `framework-integration/` references
Implementation
  • API per `.claude/ADVICE.md`
  • CSS uses v6 tokens, logical properties, nesting
  • `@summary` and JSDoc on element class
Demos
  • Demos match patternfly.org naming/structure
  • CSS custom properties match computed styles from patternfly.org (Chrome MCP)
  • Visual parity verified via Chrome MCP
Tests
  • Public API covered (attributes, properties, events, slots)
  • `a11ySnapshot` assertions
Reviews
  • `/review-api` passes
  • `/review-demos` passes
  • `/review-a11y` passes
  • `eslint` and `stylelint` pass
Ship
  • Add changeset
  • PR targets `staging/pfv6` (NOT `main`)
主要语言
TypeScript
星标
394
派生
107
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

patternfly/patternfly-elements 的其他 Issue

查看 patternfly/patternfly-elements 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。