Test CI is failing for external contributors

未关闭
#47 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
github-actions, python
领域
ci-cd, security

调研方向

Start by reading the existing test CI workflow and the linked GitHub Security Lab article, then inspect how external pull requests handle secrets and the coverage.xml artifact. Confirm the two-workflow approach in a test external-contributor scenario. Done means test CI remains safe and coverage.xml is published successfully for external contributors.

由索引模型根据 Issue 内容生成。

描述

bug

Currently, test CI is using the pull_request trigger. However, with this trigger the secrets are not populated when the PR author is external to the repository.

This is done on purpose for security reasons: https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/

Many persons on the internet suggest to use pull_request_target, but according to a rapid oversight of github securitylab article, this is only a workaround with does not help with security at all.

The proper solution seems to separate the workflow in two:

  • existing workflow will only publish the coverage.xml as an artifact
  • a new workflow will be responsible to publish this coverage.xml

Seems pretty simple to implement, but to be confirmed (I skimmed through github article way too fast) and tested of course.

主要语言
Python
星标
1
派生
2
30 天内没有已合并 PR

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

openzim/_python-bootstrap 的其他 Issue

查看 openzim/_python-bootstrap 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。