Server: the allocation sources left after #3164 (NPC scope frames, status-effect snapshot, guild member views, cast rows)
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 25/100
- Issue 类型
- 重构
- 描述清晰度
- 需要澄清
- 活跃度
- 活跃
- 技术栈
- go
- 领域
- backend, performance
调研方向
Start with the open parts: statuseffect.(*Registry).Snapshot, store.storeGuildDoor.guildMemberViewsLocked, and the cast rows in domain/social.go. For each, check which callers hold the returned copy and whether it can be shared. Run the 200-NPC/1200-published benchmark before and after each change. Done means each part reports B/op and allocs/op deltas. The open questions are design calls, so confirm the approach with maintainers first.
由索引模型根据 Issue 内容生成。
描述
Follow-up to #3164: the server allocation sources it left open.
#3164's large rows are merged:
- Character copies: #3169, #3223, #3106, and the staged bag rows in #3285.
- Ground drops: #3194's per-division delta journal.
- The commit path: the digest skip, #3229 and #3106.
The audit in #3285 names what stays.
Parts
-
simulation.NpcScopeFrames(2.8 % of allocated bytes on the live profile): reuse or recompute per tick? Called fromTicker.runSessionLegs. Reuse - #3327: oneNpcScopeBufferper division tick state, carried across the sequential session legs; steady state 19,450 -> 447 B/op, 6 -> 0 allocs/op (200-NPC/1200-published bench fixture). -
statuseffect.(*Registry).Snapshot(2.2 %): which readers need a fresh copy? -
store.storeGuildDoor.guildMemberViewsLocked(1.9 %): guild door paths. - The cast copy's rows (
domain/social.gosnapshots): taken fresh per snapshot, with no previous copy to share against. - Re-profile the live server after the next release, using #3164's method: loopback heap profile, allocated bytes per source.
Done when
- Each part reports its own before and after (benchmark B/op and allocs/op).
- The post-release live profile shows the allocation rate under #3164's 110 MB/s, with the new top sources listed.
- 主要语言
- Go
- 星标
- 97
- 派生
- 61
- 平均合并
- 4 小时 14 分钟
- 30 天内合并 PR
- 913
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
opensro-dev/opensro 的其他 Issue
-
area: client enhancement priority: low
难度 2/5 1-3 小时 新手友好度 75/100
opensro-dev/opensro#3681 ·
维护者通常 1 天内回复
-
area: client bug priority: low
难度 2/5 1-3 小时 新手友好度 78/100
opensro-dev/opensro#3228 · 1 条评论 ·
维护者通常 1 天内回复
-
Format one minified client file with dprint (ongoing: one file per PR)可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭area: client enhancement good first issue priority: low
难度 2/5 1-3 小时 新手友好度 75/100
opensro-dev/opensro#1 · 1 条评论 ·
维护者通常 1 天内回复
-
area: server bug priority: medium
难度 3/5 半天 新手友好度 55/100
opensro-dev/opensro#3687 ·
维护者通常 1 天内回复
-
area: ops bug priority: high
难度 4/5 3-5 天 新手友好度 32/100
opensro-dev/opensro#3685 ·
维护者通常 1 天内回复
查看 opensro-dev/opensro 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 66/100
unbound-force/gaze#353 ·
维护者通常 1 天内回复
-
bug cross-seed ready-for-human
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 64/100
OneBusAway/maglev#2102 ·
维护者通常 2 天内回复
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 70/100
Judgment-Pack/judgment-pack-gateway#474 ·
维护者通常 1 天内回复