Server: the allocation sources left after #3164 (NPC scope frames, status-effect snapshot, guild member views, cast rows)

Abierto
#3,291 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Refactorización
Claridad
Necesita aclaración
Estado de actividad
Activo
Stack tecnológico
go

Línea de trabajo

Start with the open parts: statuseffect.(*Registry).Snapshot, store.storeGuildDoor.guildMemberViewsLocked, and the cast rows in domain/social.go. For each, check which callers hold the returned copy and whether it can be shared. Run the 200-NPC/1200-published benchmark before and after each change. Done means each part reports B/op and allocs/op deltas. The open questions are design calls, so confirm the approach with maintainers first.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: server enhancement priority: high

Follow-up to #3164: the server allocation sources it left open.

#3164's large rows are merged:

  • Character copies: #3169, #3223, #3106, and the staged bag rows in #3285.
  • Ground drops: #3194's per-division delta journal.
  • The commit path: the digest skip, #3229 and #3106.

The audit in #3285 names what stays.

Parts

  • simulation.NpcScopeFrames (2.8 % of allocated bytes on the live profile): reuse or recompute per tick? Called from Ticker.runSessionLegs. Reuse - #3327: one NpcScopeBuffer per division tick state, carried across the sequential session legs; steady state 19,450 -> 447 B/op, 6 -> 0 allocs/op (200-NPC/1200-published bench fixture).
  • statuseffect.(*Registry).Snapshot (2.2 %): which readers need a fresh copy?
  • store.storeGuildDoor.guildMemberViewsLocked (1.9 %): guild door paths.
  • The cast copy's rows (domain/social.go snapshots): taken fresh per snapshot, with no previous copy to share against.
  • Re-profile the live server after the next release, using #3164's method: loopback heap profile, allocated bytes per source.

Done when

  • Each part reports its own before and after (benchmark B/op and allocs/op).
  • The post-release live profile shows the allocation rate under #3164's 110 MB/s, with the new top sources listed.
Lenguaje dominante
Go
Estrellas
97
Forks
61
Merge medio
4 h 14 min
PR fusionados (30 d)
913

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de opensro-dev/opensro

Todos los issues de opensro-dev/opensro

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.