Notes: extracted HtmlBlock is not wrapped by @edxnotes, so no HTML component is annotatable
维护者通常 1 天内回复
还没有人认领这个 Issue。
- #39277 来自 @florianaltendorfer —— 已关闭,未合并
评估
调研方向
Start with xmodule/html_block.py, where @edxnotes wraps only _BuiltInHtmlBlock, then read the decorator in lms.djangoapps.edxnotes.decorators and xmodule/edxnotes_utils.py. Read the diff of #38014 to see the earlier attempt. Done means an HTML component rendered with USE_EXTRACTED_HTML_BLOCK on carries the edx-notes-wrapper element, and a maintainer has chosen between reviving #38014 and adding an opt-in hook. The design choice is open, so confirm it before writing code.
由索引模型根据 Issue 内容生成。
描述
With USE_EXTRACTED_HTML_BLOCK on (the default on master and release/verawood), Student Notes cannot annotate any HTML component.
Components become annotatable through the @edxnotes decorator (xmodule/edxnotes_utils.py → lms.djangoapps.edxnotes.decorators), which wraps the student view in the edx-notes-wrapper the annotator attaches to. In xmodule/html_block.py it is applied only to _BuiltInHtmlBlock. The extracted xblocks_contrib.html.HtmlBlock (now in openedx/xblocks-core) is used undecorated.
With the notes service running and ENABLE_EDXNOTES on for the course, a unit renders the notes show/hide control and loads the annotator scripts, but no component is wrapped. There is no text a learner can select to take a note on, and the course's Notes page stays empty.
Prior work: #38014 applied @edxnotes to the extracted block. Its author closed it in February in favour of setting USE_EXTRACTED_HTML_BLOCK=False, assuming notes support would land in xblocks-contrib before the toggle is removed. I found no issue tracking that, here or in xblocks-core. Since the decorator lives in the LMS, the extracted block can't apply it itself.
Expected: HTML components are annotatable with the extracted block, as they were with the built-in one. Either revive #38014's approach, or provide a hook that lets the extracted block opt in. Notes support should also be a precondition for removing the USE_EXTRACTED_HTML_BLOCK toggle.
Environment: Tutor main with the notes plugin, xblocks-contrib 1.0.6, 2026-09-23. Code unchanged on master as of 2026-10-13. Found by the Open edX end-to-end test suite.
- 主要语言
- Python
- 星标
- 8.2k
- 派生
- 4.4k
- 平均合并
- 2 天 10 小时
- 30 天内合并 PR
- 40
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
openedx/openedx-platform 的其他 Issue
-
Discussion API: missing thread returns 500 (ForumV2RequestError not mapped to ThreadNotFoundError)可能重新可做 @mbhavu2007-lang 于 17 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
openedx/openedx-platform#39225 · 1 条评论 ·
维护者通常 1 天内回复
-
v3 notification preferences: PUT with email_cadence but no notification_channel raises KeyError (500)可能重新可做 关联的 PR 已关闭且未合并。 未关闭bug
难度 2/5 1-3 小时 新手友好度 66/100
openedx/openedx-platform#39221 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 86/100
openedx/openedx-platform#39169 · 1 条评论 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
openedx/openedx-platform#39084 ·
维护者通常 1 天内回复
-
难度 2/5 1 小时以内 新手友好度 82/100
openedx/openedx-platform#38792 ·
维护者通常 1 天内回复
查看 openedx/openedx-platform 的全部 Issue
相似的 Issue
-
area: ci bug good first issue help wanted
难度 2/5 1-3 小时 新手友好度 84/100
hffgzktbcc-blip/ounce-core#484 · 1 条评论 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 66/100
ranxianglei/billion-context#7063 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
-
needs-triage
难度 2/5 1-3 小时 新手友好度 84/100
MakazhanAlpamys/Soup#2971 ·
维护者通常 1 天内回复