cleanup: delete orphaned xmodule/js/src/html/display.js and imageModal.js

未关闭 适合新手
#38,792 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1 小时以内
新手友好度
82/100
Issue 类型
重构
描述清晰度
描述清楚
活跃度
冷清
技术栈
javascript, webpack

调研方向

等待 PR #38746 和 #38748 合并后,再检查 xmodule/js/src/html/display.js、xmodule/js/src/html/imageModal.js 和 webpack.common.config.js。确认没有 webpack entry 引用了这些文件或 xmodule/js/common_static/js/vendor/draggabilly.js,删除这两个孤立文件;如果未使用,则移除 draggabilly.js 的 imports-loader rule。

由索引模型根据 Issue 内容生成。

描述

Context

As part of the Slash-n-Burn Built-In XBlocks epic:

  • PR #38746 removes the Annotatable block, which deletes the webpack entry AnnotatableBlockDisplay — the entry that previously included xmodule/js/src/html/display.js alongside the annotatable display JS.
  • PR #38748 removes the HTML block, which deletes the webpack entry HtmlBlockDisplay — the other entry that included xmodule/js/src/html/display.js and xmodule/js/src/html/imageModal.js.

After both PRs merge, neither of these files is referenced by any webpack entry:

  • xmodule/js/src/html/display.js
  • xmodule/js/src/html/imageModal.js

They cannot be deleted in PR #38748 before PR #38746 merges (they are still referenced by AnnotatableBlockDisplay in webpack.builtinblocks.config.js on master), so this follow-up issue tracks the cleanup.

Work to do

Once both PR #38746 and PR #38748 are merged into master:

  1. Delete xmodule/js/src/html/display.js
  2. Delete xmodule/js/src/html/imageModal.js
  3. Remove the draggabilly.js imports-loader rule from webpack.common.config.js (line ~317) if no other entry references xmodule/js/common_static/js/vendor/draggabilly.js

This is a small standalone PR — should take ~5 minutes.

主要语言
Python
星标
8.2k
派生
4.4k
平均合并
2 天 10 小时
30 天内合并 PR
40

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

openedx/openedx-platform 的其他 Issue

查看 openedx/openedx-platform 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。