Allow custom message limits in flowkit client
@devbugging 已经在做这个了。
开始于 2023年7月17日。
评估
这个 Issue 还没有评估数据。
描述
Issue To Be Solved
Currently, the flowkit client uses a hardcoded max message size:
https://github.com/onflow/flow-cli/blob/6aa41a27add2d95066fc96072cc33c498f515deb/flowkit/gateway/grpc.go#L39
However, Access nodes can configure custom node specific limits to handle cases where data sizes exceed the default. This has come up several times in the last few months as data sizes have increased. Public ANs currently use a limit of 60MB.
(Optional): Suggest A Solution
We should make this limit configurable. A few potential backwards compatible solutions:
- Add a new constructor
NewCustomGrpcGatewaywhich supports passing in a client and the other fields. This could allow callers to build their own SDK client with the grpc settings they want, as well as pass their own context. - Add optional Option callbacks to allow customizing the grpc client options. This would be less flexible and require some more complex logic in the library to properly manage and pass the options into the SDK instantiation.
- Add an optional Option callback to allow specifying just the max message size. This would be simple to implement and add minimal changes to the code, but provides the least flexibility. However, it would solve the immediate problem in a simple way.
(Optional): Context
This limit is too low for GetTransactionResultByBlockID for some recent blocks, resulting the ResourceExhausted errors.
- 主要语言
- Go
- 星标
- 209
- 派生
- 88
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
onflow/flow-cli 的其他 Issue
-
Simplify MCP contract sorting with slices helpers可能已有人在做 @luangucun 于 42 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
-
`flow cadence lint` lints imports可能已有人在做 @holyfuchs 于 181 天前认领。 未关闭Bug Improvement
难度 2/5 1-3 小时 新手友好度 78/100
-
Bug
难度 3/5 1-2 天 新手友好度 48/100
-
flow test prints unreadable output可能已有人在做 @holyfuchs 于 180 天前认领。 未关闭
难度 3/5 1-2 天 新手友好度 55/100
-
Feature
难度 3/5 1-2 天 新手友好度 48/100
相似的 Issue
-
bug performance scalability
难度 2/5 1-3 小时 新手友好度 62/100
Davidjustice28/basildb#35 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
rhysd/actionlint#761 ·
-
bug needs-triage P2 tier:1-mechanical
难度 2/5 1-3 小时 新手友好度 68/100
krakenhavoc/cmd_and_ctrl#3652 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
puppe1990/amarra-cais#345 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
limitlessprojects/Go-Hybrid#50 ·
维护者通常 1 天内回复