Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Allow custom message limits in flowkit client

Aperta
#1,127 6 commenti 0 reazioni 1 assegnatario Vedi su GitHub

@devbugging ci sta già lavorando.

Dal 17/7/2023.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

Feature Feedback
Issue To Be Solved

Currently, the flowkit client uses a hardcoded max message size:
https://github.com/onflow/flow-cli/blob/6aa41a27add2d95066fc96072cc33c498f515deb/flowkit/gateway/grpc.go#L39

However, Access nodes can configure custom node specific limits to handle cases where data sizes exceed the default. This has come up several times in the last few months as data sizes have increased. Public ANs currently use a limit of 60MB.

(Optional): Suggest A Solution

We should make this limit configurable. A few potential backwards compatible solutions:

  1. Add a new constructor NewCustomGrpcGateway which supports passing in a client and the other fields. This could allow callers to build their own SDK client with the grpc settings they want, as well as pass their own context.
  2. Add optional Option callbacks to allow customizing the grpc client options. This would be less flexible and require some more complex logic in the library to properly manage and pass the options into the SDK instantiation.
  3. Add an optional Option callback to allow specifying just the max message size. This would be simple to implement and add minimal changes to the code, but provides the least flexibility. However, it would solve the immediate problem in a simple way.
(Optional): Context

This limit is too low for GetTransactionResultByBlockID for some recent blocks, resulting the ResourceExhausted errors.

Lingua principale
Go
Stelle
209
Fork
88
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di onflow/flow-cli

Tutte le issue di onflow/flow-cli

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.