BCL date/time members: `.Second` rounds (up to 60), `TimeOnly.IsBetween` across midnight, `TimeOnly - TimeOnly`, lifted `DateTimeOffset.DateTime`
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 75/100
调研方向
Start from the four translators named: NpgsqlDateTimeMemberTranslator.cs (lines 132, 209), NpgsqlDateTimeMethodTranslator.cs (300-305), NpgsqlSqlExpressionFactory.cs (460-469). Run the issue's repro to see mismatched .NET vs DB results, then fix SQL generation to floor seconds, wrap midnight, and drop the timestamptz cast. Done when all four LINQ queries return equal .NET and database values.
由索引模型根据 Issue 内容生成。
描述
| Environment | |
|---|---|
| PostgreSQL | 18.6 (postgres:18), session TimeZone Europe/Berlin (set in the repro) |
| .NET 10 | runtime 10.0.11, Npgsql.EntityFrameworkCore.PostgreSQL 10.0.3, EF Core 10.0.4 |
| .NET 11 | runtime 11.0.0-rc.2, Npgsql.EntityFrameworkCore.PostgreSQL 11.0.0-rc.2, EF Core 11.0.0-rc.2 |
| Also | Npgsql 10.0.3 on both lines, macOS arm64 |
Both lines print the same output. main at 150011d has the same code.
| LINQ | Row | .NET | PostgreSQL | SQL |
|---|---|---|---|---|
r.Timestamp.Second |
23:59:59.999 | 59 | 60 | date_part('second', r."Timestamp" AT TIME ZONE 'UTC')::int |
r.Time.IsBetween(new TimeOnly(22, 0), new TimeOnly(2, 0)) |
00:30 | true | false | r."Time" >= TIME '22:00:00' AND r."Time" < TIME '02:00:00' |
r.Time - r.Late |
00:30 − 23:00 | 01:30:00 | −22:30:00 | r."Time" - r."Late" |
(DateTime?)r.Offset.DateTime |
2026-06-15T23:30+00:00 | 2026-06-15T23:30 | 2026-06-15T21:30Z | CAST(r."Offset" AT TIME ZONE 'UTC' AS timestamp with time zone) |
Repro
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Logging;
using Npgsql;
await using var context = new TestContext();
await context.Database.EnsureDeletedAsync();
await context.Database.EnsureCreatedAsync();
context.Rows.Add(new Row
{
Timestamp = new DateTime(2026, 2, 28, 23, 59, 59, 999, DateTimeKind.Utc),
Time = new TimeOnly(0, 30),
Late = new TimeOnly(23, 0),
Offset = new DateTimeOffset(2026, 6, 15, 23, 30, 0, TimeSpan.Zero),
});
await context.SaveChangesAsync();
var row = await context.Rows.AsNoTracking().SingleAsync();
// 1. date_part('second', ...) includes the fraction and ::int rounds it
Console.WriteLine($"DateTime(23:59:59.999).Second: .NET {row.Timestamp.Second}, database {await context.Rows.Select(r => r.Timestamp.Second).SingleAsync()}");
// 2. A range that wraps midnight
Console.WriteLine($"TimeOnly(00:30).IsBetween(22:00, 02:00): .NET {row.Time.IsBetween(new TimeOnly(22, 0), new TimeOnly(2, 0))}, database {await context.Rows.Select(r => r.Time.IsBetween(new TimeOnly(22, 0), new TimeOnly(2, 0))).SingleAsync()}");
// 3. TimeOnly subtraction wraps in .NET
Console.WriteLine($"TimeOnly 00:30 - 23:00: .NET {row.Time - row.Late}, database {await context.Rows.Select(r => r.Time - r.Late).SingleAsync()}");
// 4. Lifting DateTimeOffset.DateTime to DateTime? adds a cast to timestamptz (session time zone Europe/Berlin)
Console.WriteLine($"(DateTime?)Offset.DateTime: .NET {(DateTime?)row.Offset.DateTime:O}, database {await context.Rows.Select(r => (DateTime?)r.Offset.DateTime).SingleAsync():O}");
public class TestContext : DbContext
{
public DbSet<Row> Rows => Set<Row>();
protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
=> optionsBuilder
.UseNpgsql(new NpgsqlConnectionStringBuilder(Environment.GetEnvironmentVariable("Test__Npgsql__DefaultConnection")) { Timezone = "Europe/Berlin" }.ConnectionString)
.LogTo(Console.WriteLine, LogLevel.Information)
.EnableSensitiveDataLogging();
}
public class Row
{
public int Id { get; set; }
public DateTime Timestamp { get; set; }
public TimeOnly Time { get; set; }
public TimeOnly Late { get; set; }
public DateTimeOffset Offset { get; set; }
}
Output, the same on both lines:
DateTime(23:59:59.999).Second: .NET 59, database 60
TimeOnly(00:30).IsBetween(22:00, 02:00): .NET True, database False
TimeOnly 00:30 - 23:00: .NET 01:30:00, database -22:30:00
(DateTime?)Offset.DateTime: .NET 2026-06-15T23:30:00.0000000, database 2026-06-15T21:30:00.0000000Z
.Second(NpgsqlDateTimeMemberTranslator.cs#L132):date_part('second', ...)includes the fraction, and::introunds it, so 59.999 s gives 60.Millisecondalready floors (NpgsqlDateTimeMemberTranslator.cs#L134).TimeOnly.IsBetween(NpgsqlDateTimeMethodTranslator.cs#L300-L305): a range whose start is after its end wraps around midnight in .NET, so it'st >= start OR t < end. EF's SQL Server provider translates that case.TimeOnly - TimeOnly(NpgsqlSqlExpressionFactory.cs#L460-L469): .NET wraps around midnight, so the result is always between 0 and 24 hours. PostgreSQL returns a signed interval.DateTimeOffset.DateTimeisAT TIME ZONE 'UTC'(NpgsqlDateTimeMemberTranslator.cs#L209), butAtUtckeeps the operand's CLR type,DateTimeOffset(NpgsqlSqlExpressionFactory.cs#L98-L101). Lifting the result toDateTime?adds a cast back totimestamptz, which shifts it by the session offset. The plainDateTimeprojection is correct.
- 主要语言
- C#
- 星标
- 1.8k
- 派生
- 268
- 平均合并
- 2 小时 35 分钟
- 30 天内合并 PR
- 136
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
npgsql/efcore.pg 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
NTS: the M ordinate is dropped from geometry SQL literals and from geometries stored in JSON可能已有人在做 @Ahmed7991 于 5 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 85/100
npgsql/efcore.pg#4093 · 1 条评论 ·
维护者通常 1 天内回复
-
`TimeSpan`/`Duration` component members: negative values are floored, and intervals computed in SQL are read field by field可能已有人在做 @jeremy-morren 于 11 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
Numeric storage parameters are formatted with the current culture, so migrations emit 0,01 instead of 0.01可能已有人在做 @Sorbitol 于 12 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 30/100
维护者通常 1 天内回复
-
`Contains` on a JSON primitive collection compares JSON text, so `DateTime` and `TimeOnly` items never match可能已有人在做 @Mr444-dev 于 7 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 45/100
npgsql/efcore.pg#4099 · 1 条评论 ·
维护者通常 1 天内回复
相似的 Issue
-
Issue-Bug Needs-Triage
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
JiaFeiMiao-K-Cat/DiscImageStudio#281 ·
维护者通常 1 天内回复
-
area/access-management Frontend onboarding candidate :handshake:
难度 2/5 1-3 小时 新手友好度 65/100
Altinn/altinn-auth#4941 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
aws/aws-sdk-net#4586 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
Kryptos-FR/MarkView.Avalonia#269 · 1 个 reaction ·
维护者通常 1 天内回复