BCL date/time members: `.Second` rounds (up to 60), `TimeOnly.IsBetween` across midnight, `TimeOnly - TimeOnly`, lifted `DateTimeOffset.DateTime`

Aperta
  • Qualcosa non va?
#4,090 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
75/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp, postgresql, sql
Ambito
databases

Direzione di ricerca

Start from the four translators named: NpgsqlDateTimeMemberTranslator.cs (lines 132, 209), NpgsqlDateTimeMethodTranslator.cs (300-305), NpgsqlSqlExpressionFactory.cs (460-469). Run the issue's repro to see mismatched .NET vs DB results, then fix SQL generation to floor seconds, wrap midnight, and drop the timestamptz cast. Done when all four LINQ queries return equal .NET and database values.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Environment
PostgreSQL 18.6 (postgres:18), session TimeZone Europe/Berlin (set in the repro)
.NET 10 runtime 10.0.11, Npgsql.EntityFrameworkCore.PostgreSQL 10.0.3, EF Core 10.0.4
.NET 11 runtime 11.0.0-rc.2, Npgsql.EntityFrameworkCore.PostgreSQL 11.0.0-rc.2, EF Core 11.0.0-rc.2
Also Npgsql 10.0.3 on both lines, macOS arm64

Both lines print the same output. main at 150011d has the same code.

LINQ Row .NET PostgreSQL SQL
r.Timestamp.Second 23:59:59.999 59 60 date_part('second', r."Timestamp" AT TIME ZONE 'UTC')::int
r.Time.IsBetween(new TimeOnly(22, 0), new TimeOnly(2, 0)) 00:30 true false r."Time" >= TIME '22:00:00' AND r."Time" < TIME '02:00:00'
r.Time - r.Late 00:30 − 23:00 01:30:00 −22:30:00 r."Time" - r."Late"
(DateTime?)r.Offset.DateTime 2026-06-15T23:30+00:00 2026-06-15T23:30 2026-06-15T21:30Z CAST(r."Offset" AT TIME ZONE 'UTC' AS timestamp with time zone)
Repro 
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Logging;
using Npgsql;

await using var context = new TestContext();
await context.Database.EnsureDeletedAsync();
await context.Database.EnsureCreatedAsync();

context.Rows.Add(new Row
{
    Timestamp = new DateTime(2026, 2, 28, 23, 59, 59, 999, DateTimeKind.Utc),
    Time = new TimeOnly(0, 30),
    Late = new TimeOnly(23, 0),
    Offset = new DateTimeOffset(2026, 6, 15, 23, 30, 0, TimeSpan.Zero),
});
await context.SaveChangesAsync();
var row = await context.Rows.AsNoTracking().SingleAsync();

// 1. date_part('second', ...) includes the fraction and ::int rounds it
Console.WriteLine($"DateTime(23:59:59.999).Second: .NET {row.Timestamp.Second}, database {await context.Rows.Select(r => r.Timestamp.Second).SingleAsync()}");

// 2. A range that wraps midnight
Console.WriteLine($"TimeOnly(00:30).IsBetween(22:00, 02:00): .NET {row.Time.IsBetween(new TimeOnly(22, 0), new TimeOnly(2, 0))}, database {await context.Rows.Select(r => r.Time.IsBetween(new TimeOnly(22, 0), new TimeOnly(2, 0))).SingleAsync()}");

// 3. TimeOnly subtraction wraps in .NET
Console.WriteLine($"TimeOnly 00:30 - 23:00: .NET {row.Time - row.Late}, database {await context.Rows.Select(r => r.Time - r.Late).SingleAsync()}");

// 4. Lifting DateTimeOffset.DateTime to DateTime? adds a cast to timestamptz (session time zone Europe/Berlin)
Console.WriteLine($"(DateTime?)Offset.DateTime: .NET {(DateTime?)row.Offset.DateTime:O}, database {await context.Rows.Select(r => (DateTime?)r.Offset.DateTime).SingleAsync():O}");

public class TestContext : DbContext
{
    public DbSet<Row> Rows => Set<Row>();

    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        => optionsBuilder
            .UseNpgsql(new NpgsqlConnectionStringBuilder(Environment.GetEnvironmentVariable("Test__Npgsql__DefaultConnection")) { Timezone = "Europe/Berlin" }.ConnectionString)
            .LogTo(Console.WriteLine, LogLevel.Information)
            .EnableSensitiveDataLogging();
}

public class Row
{
    public int Id { get; set; }
    public DateTime Timestamp { get; set; }
    public TimeOnly Time { get; set; }
    public TimeOnly Late { get; set; }
    public DateTimeOffset Offset { get; set; }
}

Output, the same on both lines:

DateTime(23:59:59.999).Second: .NET 59, database 60
TimeOnly(00:30).IsBetween(22:00, 02:00): .NET True, database False
TimeOnly 00:30 - 23:00: .NET 01:30:00, database -22:30:00
(DateTime?)Offset.DateTime: .NET 2026-06-15T23:30:00.0000000, database 2026-06-15T21:30:00.0000000Z
Lingua principale
C#
Stelle
1.8k
Fork
268
Merge medio
2h 35m
PR unite (30g)
136

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di npgsql/efcore.pg

Tutte le issue di npgsql/efcore.pg

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.