Proposal: run SmartOS and AIX in node-daily-master instead of node-test-pull-request
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 38/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- node.js
调研方向
先从 node-test-pull-request 和 node-test-commit 这两个 Jenkins job 开始,然后查看 node-daily-master 和 BUILDING.md,了解 Tier 2 的要求。比较这里描述的 parameter 和 separate-multijob 选项,包括仅适用于 SmartOS 的变体,并查看 #4435 以了解 executor-deadlock 的相关背景。完成的标准是:达成一致的 CI 配置将 SmartOS 和 AIX 保留在 daily CI 和 release CI 中,同时将它们从 PR gate 中移除。
由索引模型根据 Issue 内容生成。
描述
I pulled a month of node-test-pull-request history out of the Jenkins API (450 runs across 167 PRs, 2026-08-06 to 2026-09-05) to see where PR CI time goes. Most of it is waiting for an executor on two platforms rather than running tests, so i'd like to propose running SmartOS and AIX from node-daily-master only and dropping them from the PR job.
| job | runs | median | p90 | of which waiting for an executor (median / p90) | slowest configuration's own run (median) |
|---|---|---|---|---|---|
| node-test-commit-smartos | 362 | 246 min | 453 min | ~215 / ~409 min | 46 min (smartos23-x64) |
| node-test-commit-aix | 407 | 152 min | 334 min | ~87 / ~261 min | 69 min (aix73-power9) |
| node-test-commit-linux (10 configs) | 421 | 94 min | 305 min | ~22 / ~194 min | 62 min (rhel8-x64) |
| node-test-commit-osx | 433 | 91 min | 188 min | ~5 / ~105 min | 65 min (macos15-x64) |
| node-test-commit-linux-containered | 435 | 66 min | 154 min | ~17 / ~91 min | 43 min |
| node-test-commit-windows-fanned | 428 | 58 min | 192 min | ||
| node-test-commit-arm | 431 | 52 min | 112 min | ~0 / ~12 min | 45 min (rhel8-arm64) |
| node-test-commit-plinux | 442 | 35 min | 69 min | ~0 / ~22 min | 33 min |
| node-test-commit-linuxone | 447 | 30 min | 51 min | ~0 / ~6 min | 30 min |
| node-test-linter | 445 | 15 min | 20 min | ||
| node-test-pull-request, end to end | 437 | 245 min | 577 min |
"Waiting for an executor" is the matrix job's duration minus its slowest configuration's execution time (the API doesn't expose queue time for matrix children directly); aborted runs are excluded. Over the same window 13% of PR runs finished SUCCESS and another 18% UNSTABLE, the average PR needed 2.7 runs, and when exactly one child job was non-green in a run it was linuxone 34 times (nearly all yellow from marked-flaky tests), aix 19, osx 17, linux 17, windows 9, smartos 4. Raw per-configuration numbers (exec median/p90, failure rate) are available if useful.
What the change would mean in practice: SmartOS and AIX stay Tier 2 exactly as BUILDING.md defines it (full test coverage maintained, failures block releases), keep running in node-daily-master and release CI, and failures there get filed the way other daily-only jobs are handled. PRs stop holding a jenkins-workspace executor for 2-3 h while a single smartos23 executor works through the queue, which by these numbers moves the median PR run from ~4 h to ~1.5 h (osx/linux become the long pole) with no new hardware, and takes some pressure off the executor deadlocks discussed in #4435. ppc64le and s390x are also Tier 2 but have no queueing to speak of, so i'd leave them in the PR job.
Mechanically i think this is either a parameter on node-test-commit that node-test-pull-request sets to skip those two phases, or a second multijob without them for the PR trigger; whichever the WG prefers. Two questions before this goes on an agenda: is there history on why these two gate PRs specifically rather than the daily, and would anyone want a lighter variant first (e.g. keep AIX and move only SmartOS, which is the larger share of the wait)?
Refs: #4435
Refs: https://github.com/nodejs/node/pull/65826 (separate, cuts console log volume from the same jobs)
- 主要语言
- Jinja
- 星标
- 541
- 派生
- 185
- 平均合并
- 2 天 18 小时
- 30 天内合并 PR
- 6
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
nodejs/build 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
-
platform:ppc
难度 1/5 1 小时以内 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 72/100
-
incident platform:arm
难度 4/5 3-5 天 新手友好度 35/100
-
难度 4/5 3-5 天 新手友好度 45/100
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 90/100
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
typelevel/sbt-typelevel#929 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
openSUSE/python-rpm-macros#219 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 1/5 1 小时以内 新手友好度 90/100
Qiskit/mcp-servers#221 ·