[Bug]: Race condition in quota enforcement during concurrent file uploads
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
调研方向
Start by tracing quota checks for plain PUT and chunked upload v2; the issue does not name files or tests, so first locate the upload handlers and their quota enforcement tests. Reproduce with concurrent 100 MiB uploads under a 250–300 MiB quota. Done means uploads that exceed the remaining quota are rejected when sent concurrently.
由索引模型根据 Issue 内容生成。
描述
⚠️ This issue respects the following points: ⚠️
- This is not a troubleshooting question, general support matter, or webserver/proxy problem, but likely a bug (if unsure, ask the Community Help Forum).
- This issue is not already reported on Github OR solved at the Community Help Forum (I've searched!).
- I'm using a maintained major version of Nextcloud Server and tested against the latest patch level. (Supported major versions and current patch levels).
- I agree to follow Nextcloud's Code of Conduct.
- I've tried my best to provide clear reproduction steps that someone unfamiliar with this bug could use to reproduce it.
Bug description
A race condition exists in quota checking when multiple files are uploaded in parallel (both plain PUT and chunked upload v2).
When several upload requests are sent concurrently, each request performs the quota check before any of the new files have been fully written to storage. As a result, all requests can pass the quota check even if the sum of their sizes exceeds the remaining quota.
This allows an authenticated user to exceed their assigned quota.
Steps to reproduce
1.Create a user with a limited quota (e.g. 250–300 MiB).
2. Prepare a test file of 100 MiB.
3. Run the attached script in chunked or plain mode:
Expected behavior
Uploads that would exceed the remaining quota should be rejected.
Nextcloud Server version
35
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.5
Web server
Apache (supported)
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
Upgraded to a MAJOR version (ex. 31 to 32)
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
{
"system": {
"htaccess.RewriteBase": "\/",
"memcache.local": "\\OC\\Memcache\\APCu",
"apps_paths": [
{
"path": "\/var\/www\/html\/apps",
"url": "\/apps",
"writable": false
},
{
"path": "\/var\/www\/html\/custom_apps",
"url": "\/custom_apps",
"writable": true
}
],
"upgrade.disable-web": true,
"instanceid": "***REMOVED SENSITIVE VALUE***",
"passwordsalt": "***REMOVED SENSITIVE VALUE***",
"secret": "***REMOVED SENSITIVE VALUE***",
"trusted_domains": [
"localhost:8080"
],
"datadirectory": "***REMOVED SENSITIVE VALUE***",
"dbtype": "mysql",
"version": "35.0.2.2",
"overwrite.cli.url": "http:\/\/localhost:8080",
"dbname": "***REMOVED SENSITIVE VALUE***",
"dbhost": "***REMOVED SENSITIVE VALUE***",
"dbtableprefix": "oc_",
"mysql.utf8mb4": true,
"dbuser": "***REMOVED SENSITIVE VALUE***",
"dbpassword": "***REMOVED SENSITIVE VALUE***",
"installed": true,
"maintenance": false,
"loglevel": 2
}
}
List of activated Apps
Enabled:
- activity: 8.0.0
- app_api: 35.0.0
- appstore: 2.0.0
- bruteforcesettings: 8.0.0
- circles: 35.0.0
- cloud_federation_api: 2.0.0
- comments: 2.0.0
- contactsinteraction: 2.0.0
- dashboard: 8.0.0
- dav: 2.0.0
- federatedfilesharing: 2.0.0
- federation: 2.0.0
- files: 3.0.0
- files_downloadlimit: 5.3.0
- files_lock: 35.0.1
- files_pdfviewer: 8.0.0
- files_reminders: 2.0.0
- files_sharing: 2.0.0
- files_trashbin: 2.0.0
- files_versions: 2.0.0
- firstrunwizard: 8.0.0
- logreader: 8.0.0
- lookup_server_connector: 2.0.0
- nextcloud_announcements: 7.0.0
- notifications: 8.0.1
- oauth2: 2.0.0
- office: 1.1.0
- password_policy: 7.0.0
- photos: 8.0.0
- privacy: 7.0.0
- profile: 2.0.0
- provisioning_api: 2.0.0
- recommendations: 8.0.0
- related_resources: 6.0.0
- serverinfo: 7.0.0
- settings: 2.0.0
- sharebymail: 2.0.0
- sharing: 1.0.4
- support: 7.0.0
- survey_client: 7.0.0
- systemtags: 2.0.0
- text: 9.0.1
- theming: 3.0.0
- twofactor_backupcodes: 2.0.0
- twofactor_totp: 17.1.0
- updatenotification: 2.0.0
- user_status: 2.0.0
- viewer: 8.0.0
- weather_status: 2.0.0
- webhook_listeners: 2.0.0
- workflowengine: 3.0.0
Disabled:
- admin_audit: 2.0.0
- encryption: 3.0.1
- files_external: 2.0.0
- suspicious_login: 13.0.0
- twofactor_nextcloud_notification: 9.0.0
- user_ldap: 2.0.0
Nextcloud Signing status
No errors:
Nextcloud Logs
Additional info
Nextcloud Server: 35.0.2 (Docker image nextcloud:35.0.2-apache)
Operating system: Debian (Docker container); host Windows 11 Pro, Docker Desktop (WSL2)
PHP: 8.5.12
Web server: Apache 2.4.69
Database: MariaDB 11.4
Background jobs: Cron
Browser: Chrome 157
- 主要语言
- PHP
- 星标
- 37.5k
- 派生
- 5.4k
- 平均合并
- 1 天 13 小时
- 30 天内合并 PR
- 639
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
nextcloud/server 的其他 Issue
-
35-feedback
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
0. Needs triage 35-feedback bug
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
workflowengine: File entity reuses the node of the first "Tag assigned" event for all later events in the same process可能已有人在做 @lazerg 于 2 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
Contacts import aborts with TypeError when vCards have no UID (TextImporter structure)可能已有人在做 @SebastianKrupinski 于 6 天前认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 72/100
nextcloud/server#66486 · 2 条评论 · 2 个 reaction · 已指派 1 人 ·
维护者通常 1 天内回复
-
Unified search: screen reader hears "No matching results" on mobile even when there are results可能已有人在做 @lazerg 于 10 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
相似的 Issue
-
[Sync EN] stream: document the errors of the stream_context_*() and stream filter functions (#6091)未关闭sync-en
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 79/100
Automattic/blocks-engine#6318 ·
维护者通常 1 天内回复
-
Update: Laravel Cheat Sheet - middleware examples for the bootstrap/app.php layout (small update)未关闭
难度 2/5 1-3 小时 新手友好度 84/100
OWASP/CheatSheetSeries#2990 ·
维护者通常 1 天内回复
-
难度 1/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复