[Bug]: Race condition in quota enforcement during concurrent file uploads
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 48/100
Direção de pesquisa
Start by tracing quota checks for plain PUT and chunked upload v2; the issue does not name files or tests, so first locate the upload handlers and their quota enforcement tests. Reproduce with concurrent 100 MiB uploads under a 250–300 MiB quota. Done means uploads that exceed the remaining quota are rejected when sent concurrently.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
⚠️ This issue respects the following points: ⚠️
- This is not a troubleshooting question, general support matter, or webserver/proxy problem, but likely a bug (if unsure, ask the Community Help Forum).
- This issue is not already reported on Github OR solved at the Community Help Forum (I've searched!).
- I'm using a maintained major version of Nextcloud Server and tested against the latest patch level. (Supported major versions and current patch levels).
- I agree to follow Nextcloud's Code of Conduct.
- I've tried my best to provide clear reproduction steps that someone unfamiliar with this bug could use to reproduce it.
Bug description
A race condition exists in quota checking when multiple files are uploaded in parallel (both plain PUT and chunked upload v2).
When several upload requests are sent concurrently, each request performs the quota check before any of the new files have been fully written to storage. As a result, all requests can pass the quota check even if the sum of their sizes exceeds the remaining quota.
This allows an authenticated user to exceed their assigned quota.
Steps to reproduce
1.Create a user with a limited quota (e.g. 250–300 MiB).
2. Prepare a test file of 100 MiB.
3. Run the attached script in chunked or plain mode:
Expected behavior
Uploads that would exceed the remaining quota should be rejected.
Nextcloud Server version
35
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.5
Web server
Apache (supported)
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
Upgraded to a MAJOR version (ex. 31 to 32)
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
{
"system": {
"htaccess.RewriteBase": "\/",
"memcache.local": "\\OC\\Memcache\\APCu",
"apps_paths": [
{
"path": "\/var\/www\/html\/apps",
"url": "\/apps",
"writable": false
},
{
"path": "\/var\/www\/html\/custom_apps",
"url": "\/custom_apps",
"writable": true
}
],
"upgrade.disable-web": true,
"instanceid": "***REMOVED SENSITIVE VALUE***",
"passwordsalt": "***REMOVED SENSITIVE VALUE***",
"secret": "***REMOVED SENSITIVE VALUE***",
"trusted_domains": [
"localhost:8080"
],
"datadirectory": "***REMOVED SENSITIVE VALUE***",
"dbtype": "mysql",
"version": "35.0.2.2",
"overwrite.cli.url": "http:\/\/localhost:8080",
"dbname": "***REMOVED SENSITIVE VALUE***",
"dbhost": "***REMOVED SENSITIVE VALUE***",
"dbtableprefix": "oc_",
"mysql.utf8mb4": true,
"dbuser": "***REMOVED SENSITIVE VALUE***",
"dbpassword": "***REMOVED SENSITIVE VALUE***",
"installed": true,
"maintenance": false,
"loglevel": 2
}
}
List of activated Apps
Enabled:
- activity: 8.0.0
- app_api: 35.0.0
- appstore: 2.0.0
- bruteforcesettings: 8.0.0
- circles: 35.0.0
- cloud_federation_api: 2.0.0
- comments: 2.0.0
- contactsinteraction: 2.0.0
- dashboard: 8.0.0
- dav: 2.0.0
- federatedfilesharing: 2.0.0
- federation: 2.0.0
- files: 3.0.0
- files_downloadlimit: 5.3.0
- files_lock: 35.0.1
- files_pdfviewer: 8.0.0
- files_reminders: 2.0.0
- files_sharing: 2.0.0
- files_trashbin: 2.0.0
- files_versions: 2.0.0
- firstrunwizard: 8.0.0
- logreader: 8.0.0
- lookup_server_connector: 2.0.0
- nextcloud_announcements: 7.0.0
- notifications: 8.0.1
- oauth2: 2.0.0
- office: 1.1.0
- password_policy: 7.0.0
- photos: 8.0.0
- privacy: 7.0.0
- profile: 2.0.0
- provisioning_api: 2.0.0
- recommendations: 8.0.0
- related_resources: 6.0.0
- serverinfo: 7.0.0
- settings: 2.0.0
- sharebymail: 2.0.0
- sharing: 1.0.4
- support: 7.0.0
- survey_client: 7.0.0
- systemtags: 2.0.0
- text: 9.0.1
- theming: 3.0.0
- twofactor_backupcodes: 2.0.0
- twofactor_totp: 17.1.0
- updatenotification: 2.0.0
- user_status: 2.0.0
- viewer: 8.0.0
- weather_status: 2.0.0
- webhook_listeners: 2.0.0
- workflowengine: 3.0.0
Disabled:
- admin_audit: 2.0.0
- encryption: 3.0.1
- files_external: 2.0.0
- suspicious_login: 13.0.0
- twofactor_nextcloud_notification: 9.0.0
- user_ldap: 2.0.0
Nextcloud Signing status
No errors:
Nextcloud Logs
Additional info
Nextcloud Server: 35.0.2 (Docker image nextcloud:35.0.2-apache)
Operating system: Debian (Docker container); host Windows 11 Pro, Docker Desktop (WSL2)
PHP: 8.5.12
Web server: Apache 2.4.69
Database: MariaDB 11.4
Background jobs: Cron
Browser: Chrome 157
- Linguagem predominante
- PHP
- Estrelas
- 37.5k
- Forks
- 5.4k
- Merge médio
- 1d 13h
- PRs com merge (30d)
- 639
Preparar o ambiente
Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de nextcloud/server
-
35-feedback
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
Mantenedores costumam responder em até 1 dia
-
0. Needs triage 35-feedback bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 66/100
Mantenedores costumam responder em até 1 dia
-
workflowengine: File entity reuses the node of the first "Tag assigned" event for all later events in the same processTalvez já em andamento @lazerg assumiu há 2 dias. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
Mantenedores costumam responder em até 1 dia
-
Contacts import aborts with TypeError when vCards have no UID (TextImporter structure)Talvez já em andamento @SebastianKrupinski assumiu há 6 dias. Abertabug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
nextcloud/server#66486 · 2 comentários · 2 reações · 1 responsável ·
Mantenedores costumam responder em até 1 dia
-
Unified search: screen reader hears "No matching results" on mobile even when there are resultsTalvez já em andamento @lazerg assumiu há 10 dias. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
Mantenedores costumam responder em até 1 dia
Todas as issues de nextcloud/server
Issues semelhantes
-
[Sync EN] stream: document the errors of the stream_context_*() and stream filter functions (#6091)Abertasync-en
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 66/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 79/100
Automattic/blocks-engine#6318 ·
Mantenedores costumam responder em até 1 dia
-
Update: Laravel Cheat Sheet - middleware examples for the bootstrap/app.php layout (small update)Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
OWASP/CheatSheetSeries#2990 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 1/5 1-3 horas Facilidade para iniciantes 82/100
Mantenedores costumam responder em até 1 dia