spike: audit the test suites for duplication, usefulness and structure

未关闭
  • 哪里不对？
#435 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
csharp, javascript
领域
testing-qa

调研方向

Start by confirming the listed test locations and file sizes: TaskFlow.Api.Tests, TaskFlow.Web/src, and assistant/tests; inspect TestSupport.cs and the API Helpers/ folder for repeated setup. Run Stryker.NET and StrykerJS on one representative slice per area, recording setup cost, runtime, mutation results, and full test runtimes with the slowest files. Post the requested area tables, recommend grouping and a size limit, update the agent wording once agreed, and record whether to create a test-curator with follow-up issues if needed.

由索引模型根据 Issue 内容生成。

描述

tech-debt

Found while reviewing the test-verifier agent for #400 (piece 8). The test suites have grown large, and part of the growth comes from our own instructions ("extend the existing test file rather than creating a parallel one"). This spike measures the problem and decides what to do about it before anyone builds a tool.

What I found

Area Test code Tests Notes
API (TaskFlow.Api.Tests) about 19,400 lines 946 Five files cover TaskItemsController (about 4,300 lines together) and overlap in topic: TaskItemsControllerV1Tests, ...ParentCompletedTests, ...PatchTests, ...JournalDateMockedTests, and others.
Web (TaskFlow.Web/src) about 21,300 lines 1,650 in 99 files Several files of 600 to 1,000 lines; four CSS-contract style tests.
Assistant (assistant/tests) about 5,100 lines 348 in 3 files TaskToolsTests.cs is 2,973 lines.
  • The API tests have no shared builder or fixture folder that I could find (their Helpers/ folder tests production helpers). The assistant has TestSupport.cs (234 lines) and the web has src/test/. This needs confirming.
  • Line coverage (75% API, 80% web) says a line ran, not that a test is useful. Deleting tests risks the gates, so the gates cannot be the only measure.

Scope

  1. Structure. For each area, find overlapping test files, files over a size threshold, setup repeated across files, and helpers that should be shared. Propose a grouping rule (by behavior, a size limit) to replace "extend the existing file".
  2. Usefulness. Find tests that only assert a mock was called, restate what a lower or higher layer already proves, or have no meaningful assertion. Use mutation testing (Stryker.NET for the API and assistant, StrykerJS for the web) on one representative slice per area: tests that kill no mutant that another test does not also kill are candidates to remove. Record the run time and setup cost of each tool.
  3. Cost. Record the current full test run time per area and what the slowest files are.
  4. Decide what to do. Compare: a series of ordinary cleanup PRs, or a test-curator agent and skill run by hand on one area at a time to produce behavior-preserving refactor PRs. Recommend one, with an estimate.
  5. If an agent is recommended, state the proof it must give with each PR: coverage gates unchanged and mutation score no lower.

Acceptance criteria

  1. A table is posted on this issue for each area: files over the proposed size limit, overlapping files, repeated setup, and candidate shared helpers.
  2. Mutation results for one slice per area are posted, with the tool setup and run time, or the issue says why a tool was dropped.
  3. A recommended file grouping and size rule is posted, and the "extend the existing test file" wording in the agents is replaced with it once agreed.
  4. A recommendation is recorded on whether to build a test-curator, with follow-up issues opened if so.

Out of scope

  • Doing the refactor. This issue produces a decision and follow-up issues.
  • Changing the coverage gates.
  • The test-verifier's probing and usefulness bar. #400 decided those and carries them.
主要语言
C#
星标
1
派生
0
平均合并
2 小时 2 分钟
30 天内合并 PR
98

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

nevridge/TaskFlow 的其他 Issue

查看 nevridge/TaskFlow 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。