spike: audit the test suites for duplication, usefulness and structure
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
- issue の種類
- 機能追加
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- csharp, javascript
- 領域
- testing-qa
調査の方向性
Start by confirming the listed test locations and file sizes: TaskFlow.Api.Tests, TaskFlow.Web/src, and assistant/tests; inspect TestSupport.cs and the API Helpers/ folder for repeated setup. Run Stryker.NET and StrykerJS on one representative slice per area, recording setup cost, runtime, mutation results, and full test runtimes with the slowest files. Post the requested area tables, recommend grouping and a size limit, update the agent wording once agreed, and record whether to create a test-curator with follow-up issues if needed.
索引モデルが issue の本文から書いたものです。
説明
Found while reviewing the test-verifier agent for #400 (piece 8). The test suites have grown large, and part of the growth comes from our own instructions ("extend the existing test file rather than creating a parallel one"). This spike measures the problem and decides what to do about it before anyone builds a tool.
What I found
| Area | Test code | Tests | Notes |
|---|---|---|---|
API (TaskFlow.Api.Tests) |
about 19,400 lines | 946 | Five files cover TaskItemsController (about 4,300 lines together) and overlap in topic: TaskItemsControllerV1Tests, ...ParentCompletedTests, ...PatchTests, ...JournalDateMockedTests, and others. |
Web (TaskFlow.Web/src) |
about 21,300 lines | 1,650 in 99 files | Several files of 600 to 1,000 lines; four CSS-contract style tests. |
Assistant (assistant/tests) |
about 5,100 lines | 348 in 3 files | TaskToolsTests.cs is 2,973 lines. |
- The API tests have no shared builder or fixture folder that I could find (their
Helpers/folder tests production helpers). The assistant hasTestSupport.cs(234 lines) and the web hassrc/test/. This needs confirming. - Line coverage (75% API, 80% web) says a line ran, not that a test is useful. Deleting tests risks the gates, so the gates cannot be the only measure.
Scope
- Structure. For each area, find overlapping test files, files over a size threshold, setup repeated across files, and helpers that should be shared. Propose a grouping rule (by behavior, a size limit) to replace "extend the existing file".
- Usefulness. Find tests that only assert a mock was called, restate what a lower or higher layer already proves, or have no meaningful assertion. Use mutation testing (Stryker.NET for the API and assistant, StrykerJS for the web) on one representative slice per area: tests that kill no mutant that another test does not also kill are candidates to remove. Record the run time and setup cost of each tool.
- Cost. Record the current full test run time per area and what the slowest files are.
- Decide what to do. Compare: a series of ordinary cleanup PRs, or a
test-curatoragent and skill run by hand on one area at a time to produce behavior-preserving refactor PRs. Recommend one, with an estimate. - If an agent is recommended, state the proof it must give with each PR: coverage gates unchanged and mutation score no lower.
Acceptance criteria
- A table is posted on this issue for each area: files over the proposed size limit, overlapping files, repeated setup, and candidate shared helpers.
- Mutation results for one slice per area are posted, with the tool setup and run time, or the issue says why a tool was dropped.
- A recommended file grouping and size rule is posted, and the "extend the existing test file" wording in the agents is replaced with it once agreed.
- A recommendation is recorded on whether to build a
test-curator, with follow-up issues opened if so.
Out of scope
- Doing the refactor. This issue produces a decision and follow-up issues.
- Changing the coverage gates.
- The test-verifier's probing and usefulness bar. #400 decided those and carries them.
- 主要言語
- C#
- スター
- 1
- フォーク
- 0
- 平均マージ
- 2時間 2分
- マージ済み PR（30日）
- 98
環境構築
- Dockerfile または Docker Compose ファイルあり
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
nevridge/TaskFlow のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
メンテナーはふだん 1 日以内に返信
-
tech-debt
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
nevridge/TaskFlow の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
juandresrodca/AdminForge#54 ·
-
要トリアージ 辞書
難易度 1/5 1〜3時間 初心者へのやさしさ 86/100
yksr-melt/Meltype#1625 · リアクション 1 件 ·
メンテナーはふだん 1 日以内に返信
-
Docs typoオープン
難易度 1/5 1時間未満 初心者へのやさしさ 78/100
MonoGame/docs.monogame.github.io#328 · コメント 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
space-wizards/RobustToolbox#7197 ·
メンテナーはふだん 1 日以内に返信
-
documentation high priority
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
lachydotmcg/capri-desktop#201 ·
メンテナーはふだん 1 日以内に返信