LargeFileUploadTask not using GraphError
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 45/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- typescript
- 领域
- api
调研方向
Start with LargeFileUploadTask.ts around line 260, then trace the response handling through GraphResponseHandler.ts around lines 95 and 176-179. Confirm how upload errors are propagated and ensure an API error from LargeFileUploadTask is exposed as a GraphError rather than the raw response object.
由索引模型根据 Issue 内容生成。
描述
Bug Report
Prerequisites
- Can you reproduce the problem?
- Are you running the latest version?
- Are you reporting to the correct repository?
- Did you perform a cursory search?
Description
Errors thrown during a LargeFileUploadTask are not wrapped with GraphError.
Please correct me if I'm wrong, but I was expecting all errors from the API to be wrapped in that class.
In our case, this happened when running multiple uploads, but I think the specific error is irrelevant.
Screenshots:
You can see in the screenshot that the "error object" is just the direct response from the API:
https://learn.microsoft.com/en-us/graph/errors#json-representation
Steps to Reproduce
Not sure what to add here, I think this applies to any error during an upload task. We're experiencing this when trying to send multiple emails at once, all with attachments. This causes the MailboxConcurrency error to be thrown.
Expected behavior:
Error to be an instance of GraphError.
Actual behavior:
Error is actually the response object returned by the API.
Additional Context
I've tried to track this down, but it's my first time actually browsing the SDK code.
- Upload task tries to handle response: https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/0f8eb690d571c37d9a8df1b8564e8a46ba46829a/src/tasks/LargeFileUploadTask.ts#L260
- I'm assuming it's then calling
GraphResponseHandler.convertResponse: https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/0f8eb690d571c37d9a8df1b8564e8a46ba46829a/src/GraphResponseHandler.ts#L95 - Again, I'm assuming it goes on the
elsebranch and directly throws the response from the API: https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/0f8eb690d571c37d9a8df1b8564e8a46ba46829a/src/GraphResponseHandler.ts#L176-L179
Usage Information
Request ID - Value of the requestId field if you are receiving a Graph API error response
SDK Version - 3.0.6
- Node (Check, if using Node version of SDK)
Node Version - 18.15.0
- 主要语言
- TypeScript
- 星标
- 833
- 派生
- 240
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
microsoftgraph/msgraph-sdk-javascript 的其他 Issue
-
status:waiting-for-triage
难度 1/5 1 小时以内 新手友好度 62/100
-
Is anyone here? 未关闭
难度 4/5 3-5 天 新手友好度 25/100
microsoftgraph/msgraph-sdk-javascript#2005 · 1 个 reaction ·
-
status:waiting-for-triage
难度 5/5 一周以上 新手友好度 42/100
-
status:waiting-for-triage type:bug
难度 3/5 1-2 天 新手友好度 48/100
microsoftgraph/msgraph-sdk-javascript#1999 · 2 条评论 · 1 个 reaction ·
-
status:waiting-for-triage type:bug
难度 4/5 3-5 天 新手友好度 45/100
查看 microsoftgraph/msgraph-sdk-javascript 的全部 Issue
相似的 Issue
-
VerificationGate: ATTRIBUTION quote guard never matches a normal quotation (\b around the quote) 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
danielmiessler/LifeOS#2234 ·
-
T: Bug
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 1/5 1 小时以内 新手友好度 85/100
-
Mend: dependency security vulnerability untriaged
难度 2/5 1-3 小时 新手友好度 70/100