LargeFileUploadTask not using GraphError

Aperta
#1,557 1 commento 1 reazione 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
typescript
Ambito
api

Direzione di ricerca

Start with LargeFileUploadTask.ts around line 260, then trace the response handling through GraphResponseHandler.ts around lines 95 and 176-179. Confirm how upload errors are propagated and ensure an API error from LargeFileUploadTask is exposed as a GraphError rather than the raw response object.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Bug Report

Prerequisites

  • Can you reproduce the problem?
  • Are you running the latest version?
  • Are you reporting to the correct repository?
  • Did you perform a cursory search?

Description

Errors thrown during a LargeFileUploadTask are not wrapped with GraphError.
Please correct me if I'm wrong, but I was expecting all errors from the API to be wrapped in that class.

In our case, this happened when running multiple uploads, but I think the specific error is irrelevant.

Screenshots:
image

You can see in the screenshot that the "error object" is just the direct response from the API:
https://learn.microsoft.com/en-us/graph/errors#json-representation

Steps to Reproduce

Not sure what to add here, I think this applies to any error during an upload task. We're experiencing this when trying to send multiple emails at once, all with attachments. This causes the MailboxConcurrency error to be thrown.

Expected behavior:
Error to be an instance of GraphError.

Actual behavior:
Error is actually the response object returned by the API.

Additional Context

I've tried to track this down, but it's my first time actually browsing the SDK code.

  1. Upload task tries to handle response: https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/0f8eb690d571c37d9a8df1b8564e8a46ba46829a/src/tasks/LargeFileUploadTask.ts#L260
  2. I'm assuming it's then calling GraphResponseHandler.convertResponse: https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/0f8eb690d571c37d9a8df1b8564e8a46ba46829a/src/GraphResponseHandler.ts#L95
  3. Again, I'm assuming it goes on the else branch and directly throws the response from the API: https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/0f8eb690d571c37d9a8df1b8564e8a46ba46829a/src/GraphResponseHandler.ts#L176-L179

Usage Information

Request ID - Value of the requestId field if you are receiving a Graph API error response

SDK Version - 3.0.6

  • Node (Check, if using Node version of SDK)

Node Version - 18.15.0

Lingua principale
TypeScript
Stelle
833
Fork
240
Nessuna PR unita negli ultimi 30g

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoftgraph/msgraph-sdk-javascript

Tutte le issue di microsoftgraph/msgraph-sdk-javascript

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.