skillopt-sleep: max_tokens_per_night is defaulted and documented but never enforced
维护者通常 2 天内回复
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- python
调研方向
Read skillopt_sleep/config.py and skillopt_sleep/budget.py, then trace the cycle entry point to see how model calls and report.md are handled. Decide whether to enforce the configured token cap through Budget or remove the unused setting and its documentation; done means the chosen behavior is consistent and the reported configuration no longer promises an unenforced cap.
由索引模型根据 Issue 内容生成。
描述
What happens
skillopt_sleep/config.py defines "max_tokens_per_night": 400_000 under the budgets section, and skillopt_sleep/budget.py has a Budget controller that "stops cleanly when exhausted and reports what it skipped". Nothing connects them on main: the key is never read outside DEFAULTS, and Budget( is never constructed. A night's spend is therefore bounded only by max_tasks_per_night, edit_budget and the number of fan-out skill groups, while the config suggests a token cap.
How to check
Version: main at 343db229dbd5ddaf9df6b1d5540d8bcdb2604d5c (uv tool install from git), Python 3.14, macOS.
P=$(python -c 'import skillopt_sleep, os; print(os.path.dirname(skillopt_sleep.__file__))')
rg -n 'max_tokens_per_night' "$P" # only config.py DEFAULTS
rg -n 'Budget\(' "$P" # only the class definition in budget.py
This was also noted in passing in the closed feedback issue #57 ("max_tokens_per_night exists, but no real budget enforcement"); that issue was closed for its other points, and the budget is still not enforced at 343db229.
Request
Either wire max_tokens_per_night (and optionally a wall-clock cap) into the cycle through Budget, stopping before the next model call once it is spent and saying so in report.md, or remove the key from DEFAULTS and the docs so users do not rely on it.
- 主要语言
- Python
- 星标
- 18.2k
- 派生
- 1.7k
- 平均合并
- 4 天 1 小时
- 30 天内合并 PR
- 10
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
microsoft/SkillOpt 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 45/100
维护者通常 2 天内回复
-
难度 3/5 1-2 天 新手友好度 66/100
维护者通常 2 天内回复
-
难度 4/5 3-5 天 新手友好度 25/100
维护者通常 2 天内回复
-
Clarification on Rollout Timeouts, Inference Concurrency, and Their Impact on SkillOpt Evaluation未关闭
难度 4/5 3-5 天 新手友好度 12/100
维护者通常 2 天内回复
-
难度 5/5 一周以上 新手友好度 32/100
维护者通常 2 天内回复
查看 microsoft/SkillOpt 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 82/100
EchoTools/nevr-runtime#651 ·
维护者通常 1 天内回复
-
bug frontend rt sev-3
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
noontide-co/mainbranch#1211 · 1 条评论 ·
维护者通常 1 天内回复
-
[1.x Bug] run-operation --sql reports success but rolls back writes on transaction-capable adapters未关闭triage
难度 2/5 1-3 小时 新手友好度 64/100
维护者通常 1 天内回复