fix(ci): signed-commit check fails pr-refine on PRs over 250 commits even when the lane made no commits
维护者通常 1 天内回复
评估
调研方向
Start with .github/actions/check-signed-commits/check-signed-commits.mjs, especially the 250-commit cap, completeness check, and escalation label request. Trace how the action identifies commits made by the lane and how it handles a lane with no commits; use the observed run on #7009 as a reference. Done means the check covers only the lane's commits, skips empty lanes, and a failed label write warns without failing the job.
由索引模型根据 Issue 内容生成。
描述
Problem
On a pull request with more than 250 commits, pr-refine / fix-docs fails even when the lane made no commits.
.github/actions/check-signed-commits/check-signed-commits.mjs:14setsLISTED_COMMITS_CAP=250. Past the cap, line 92 setscomplete=false, soallVerifiedis false even when every listed commit is verified.- The escalation then POSTs a label to
issues/<n>/labels. That fails with 403 because the token has no issues write, and the failed POST becomes a hard failure. - The check runs even when the lane produced no commits ("The activity made no commits"), so there is nothing of the lane's to check.
Observed on #7009 (259 commits), run 38179498135: check-run summary "A commit on the pull request is not GitHub-verified."; step "Check the lane's commits are signed": "POST .../issues/7009/labels failed with status 403".
Expected
- Skip the signed-commit check when the lane made no commits.
- Check only the lane's own commits, not the PR's full history, so the 250-commit list cap does not apply.
- A failed escalation label write should be a warning, not a job failure.
- 主要语言
- Shell
- 星标
- 22
- 派生
- 2
- 平均合并
- 8 小时 41 分钟
- 30 天内合并 PR
- 892
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
melodic-software/claude-code-plugins 的其他 Issue
-
good first issue needs-human priority: low work-class: mechanical
难度 2/5 1-3 小时 新手友好度 92/100
melodic-software/claude-code-plugins#8023 · 1 条评论 ·
维护者通常 1 天内回复
-
needs-human work-class: mechanical
难度 2/5 1-3 小时 新手友好度 76/100
melodic-software/claude-code-plugins#8021 ·
维护者通常 1 天内回复
-
needs-human work-class: scoped
难度 2/5 1-3 小时 新手友好度 84/100
melodic-software/claude-code-plugins#8018 ·
维护者通常 1 天内回复
-
docs(planning): point the interview surface context at the surface README instead of restating it未关闭needs-human work-class: mechanical
难度 2/5 1-3 小时 新手友好度 78/100
melodic-software/claude-code-plugins#8015 ·
维护者通常 1 天内回复
-
needs-human work-class: mechanical
难度 2/5 1-3 小时 新手友好度 86/100
melodic-software/claude-code-plugins#8004 ·
维护者通常 1 天内回复
查看 melodic-software/claude-code-plugins 的全部 Issue
相似的 Issue
-
bug good first issue
难度 2/5 1-3 小时 新手友好度 68/100
scarif-labs/horus#61 ·
维护者通常 1 天内回复
-
documentation
难度 2/5 1-3 小时 新手友好度 88/100
IntersectMBO/developer-experience#362 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
registrystack/registry-stack#2168 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 92/100
维护者通常 2 天内回复
-
[Bug]: Grep inherits RIPGREP_CONFIG_PATH and can silently change regex search results可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭Bug triage/confirmed
难度 2/5 半天 新手友好度 85/100
agentscope-ai/agentscope#3355 ·
维护者通常 2 天内回复