Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

fix(ci): signed-commit check fails pr-refine on PRs over 250 commits even when the lane made no commits

Abierto
  • ¿Algo no está bien?
#7,256 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
57/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
github-actions, shell
Área
ci-cd

Línea de trabajo

Start with .github/actions/check-signed-commits/check-signed-commits.mjs, especially the 250-commit cap, completeness check, and escalation label request. Trace how the action identifies commits made by the lane and how it handles a lane with no commits; use the observed run on #7009 as a reference. Done means the check covers only the lane's commits, skips empty lanes, and a failed label write warns without failing the job.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

needs-triage priority: medium

Problem

On a pull request with more than 250 commits, pr-refine / fix-docs fails even when the lane made no commits.

  • .github/actions/check-signed-commits/check-signed-commits.mjs:14 sets LISTED_COMMITS_CAP=250. Past the cap, line 92 sets complete=false, so allVerified is false even when every listed commit is verified.
  • The escalation then POSTs a label to issues/<n>/labels. That fails with 403 because the token has no issues write, and the failed POST becomes a hard failure.
  • The check runs even when the lane produced no commits ("The activity made no commits"), so there is nothing of the lane's to check.

Observed on #7009 (259 commits), run 38179498135: check-run summary "A commit on the pull request is not GitHub-verified."; step "Check the lane's commits are signed": "POST .../issues/7009/labels failed with status 403".

Expected

  • Skip the signed-commit check when the lane made no commits.
  • Check only the lane's own commits, not the PR's full history, so the 250-commit list cap does not apply.
  • A failed escalation label write should be a warning, not a job failure.
Lenguaje dominante
Shell
Estrellas
22
Forks
2
Merge medio
7 h 42 min
PR fusionados (30 d)
923

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de melodic-software/claude-code-plugins

Todos los issues de melodic-software/claude-code-plugins

Issues similares

Más issues de Shell/Bash

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.