Add event-based device discovery

未关闭
#328 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
rust

调研方向

Start by reading the device discovery and NFC/USB handling entry points; the issue does not name specific files or tests. Work out how the library represents FIDO devices and asynchronous events, then define an API for connection and disconnection notifications, including cancellation and device lifetimes. Done means callers can track devices as they connect and disconnect without polling.

由索引模型根据 Issue 内容生成。

描述

One thing I noticed is that we treat NFC readers like FIDO devices, but they're more akin to the Bluetooth adapter or USB host. I think we need to add an API to await the presence of a FIDO adapter on any NFC reader notifies that the a key is connected. I think doing something similar would be useful for USB too.

An example of what I'm thinking (might not be the best API):

/// Stream HID devices with FIDO usage pages as they connect and disconnect.
fn discover_devices(cancellation_token: CancellationToken): impl Stream<Output = HidDeviceEvent> { }

// The caller would likely want to collect the full list of devices
let devices: Arc<Mutex<HashMap<String, HidDevice>>> = Mutex::new(HashMap::new());

while let Some(device) = usb::discover_devices(cancellation_token).next().await {
  let devices = devices.clone();
  match event {
    // A HID device filters for devices with FIDO usage pages.
    // Open FIDO channel on connection
    HidDeviceEvent::Connected(id, device) => {
      let process_device_fut = async move {
        let channel = device.channel().await;
        // the device object will have to live longer than the monitor object, or else we'll have to do something funky with lifetimes.
        devices.lock().unwrap().insert(id, device);
        // process device
      });
      tokio::spawn(cancellation_token.child_token().run_until_cancelled(process_device_fut));
    },
    HidDeviceEvent::Disconnected(id) => {
      devices.lock().unwrap().remove(id);
    }
  }    
});

This allows caller to keep track of candidate devices as they come and go without spending CPU time polling or having to re-arm the request during a ceremony.

Maybe some of this could be abstracted into a monitor object for an easier to use API.

This can be useful for https://github.com/linux-credentials/credentialsd/issues/256.

主要语言
Rust
星标
602
派生
33
平均合并
1 天 13 小时
30 天内合并 PR
9

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

linux-credentials/libwebauthn 的其他 Issue

查看 linux-credentials/libwebauthn 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。