AppId extension processing missing TrustedFacetList processing

未关闭
#326 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
52/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
rust

调研方向

Start with the AppId validation algorithm in libwebauthn/src/ops/webauthn/idl/mod.rs and compare it with the related-origins resolution path mentioned in the error log. Trace how an AppId is fetched and authorized, then determine how TrustedFacetList entries should affect the Google example. Done means an origin listed as a trusted facet can complete with appid: true, with coverage for this case.

由索引模型根据 Issue 内容生成。

描述

We use a reduction of AppId processing, e.g. stopping at step 3 above by just comparing the origin to the AppId hostname, but this doesn't work for sites that host the TrustedFacetList on a domain that is not equal to or a subdomain of the origin. Unfortunately, Google's implementation fits this category, so U2F credentials cannot be asserted with libwebauthn right now.

When logging in on https://accounts.google.com, these are the relevant inputs:

origin: https://accounts.google.com
rpId: google.com
appId: https://www.gstatic.com/securitykey/origins.json

Google's TrustedFacetList for that appId:

{
  "trustedFacets": [
    {
      "version": { "major": 1, "minor": 0 },
      "ids": [
        "https://accounts.google.com",
        "https://accounts-daily-0.sandbox.google.com",
        "https://accounts-daily-1.sandbox.google.com",
        "https://accounts-daily-2.sandbox.google.com",
        "https://accounts-daily-3.sandbox.google.com",
        "https://accounts-daily-4.sandbox.google.com",
        "https://accounts-daily-5.sandbox.google.com",
        "https://accounts-daily-6.sandbox.google.com",
        "https://accounts.sandbox.google.com",
        "https://myaccount.google.com",
        "https://myaccount-autopush.corp.google.com",
        "https://myaccount-staging.corp.google.com",
        "https://security.google.com",
        "https://admin.google.com",
        "https://admin-autopush.sandbox.google.com",
        "android:apk-key-hash:8P1sW0EPJcslw7UzRsiXL64w-O50Ed-RBICtay1g24M",
        "android:apk-key-hash:GXWy8XF3vIml3_MfnmSmyuKBpT3B0dWbHRR_4cgq-gA",
        "ios:bundle-id:com.google.GoogleAccounts.dev",
        "ios:bundle-id:com.google.GoogleAccounts.enterprise",
        "ios:bundle-id:com.google.GoogleAccounts",
        "ios:bundle-id:com.google.SecurityKeyExample.dev",
        "native://cloud.google.com/googlecloudsdk"
      ]
    }
  ]
}

In this case, I would expect the RP ID to be ignored and the ceremony to complete with appid: true, since the origin is in the trusted facet list. However, this is what I experience:

2026-11-04T23:17:20.533276Z DEBUG reqwest::connect: starting new connection: https://www.gstatic.com/
2026-11-04T23:17:20.534321Z DEBUG hyper_util::client::legacy::connect::http: connecting to 142.250.177.67:443
2026-11-04T23:17:20.545734Z DEBUG hyper_util::client::legacy::connect::http: connected to 142.250.177.67:443
2026-11-04T23:17:20.566396Z DEBUG h2::client: binding client connection
2026-11-04T23:17:20.566643Z DEBUG h2::client: client connection bound
2026-11-04T23:17:20.566698Z DEBUG h2::codec::framed_write: send frame=Settings { flags: (0x0), enable_push: 0, initial_window_size: 2097152, max_frame_size: 16384, max_header_list_size: 16384 }
2026-11-04T23:17:20.566886Z DEBUG hyper_util::client::legacy::pool: pooling idle connection for ("https", www.gstatic.com)
...
2026-11-04T23:17:20.585898Z DEBUG libwebauthn::ops::webauthn::idl: Related-origins resolution failed rp_id=www.gstatic.com err=unexpected HTTP status 404
2026-11-04T23:17:20.585957Z  INFO credentialsd::gateway::util: Failed to parse GetAssertion request JSON: Invalid AppID: appid is not authorised for the caller origin
2026-11-04T23:17:20.586058Z ERROR credentialsd::gateway: Could not parse passkey assertion request: TypeError

The current algorithm assumes that the origin is always AppId is registrable domain suffix, but sites that host the facet list on a separate domain will fail according to our implementation.

I think we should add an AppId fetcher, like we have for related origins, and then process the list accordingly.

主要语言
Rust
星标
602
派生
33
平均合并
1 天 13 小时
30 天内合并 PR
9

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

linux-credentials/libwebauthn 的其他 Issue

查看 linux-credentials/libwebauthn 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。