Django exceptions reach DRF as 500

未关闭
#6,391 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
django, python

调研方向

Start with contentcuration/contentcuration/viewsets/base.py and the serialize_object behavior linked in the issue, then read the related DRF views and the exception handler strategy in #6387. Add regression tests for each input listed in Context and verify malformed detail-route pks return 404, invalid parameters and submission states return 400, and Django ObjectDoesNotExist returns 404.

由索引模型根据 Issue 内容生成。

描述

DEV: backend

Overview

Some code raises Django's ValidationError, ObjectDoesNotExist or FieldError inside DRF views. DRF converts only its own exceptions, Http404 and PermissionDenied, so these return 500. BaseValuesViewset.serialize_object also crashes on some malformed pks before it can return its 404.

Complexity: Medium
Target branch: hotfixes

Context

All inputs below were reproduced:

  • BaseValuesViewset.serialize_object:
    • On a model with an integer pk, GET /api/assessmentitem/abc raises UnboundLocalError, because .filter() fails before queryset is assigned. Kolibri fixed this in learningequality/kolibri@eeb4c8207e.
    • On SavedSearch, whose pk is a Django UUIDField, GET /api/search/saved-search/abc raises Django ValidationError, which isn't in the caught tuple.
    • Affected detail routes: assessmentitem, user, admin-users, bookmark, channeluser, communitylibrary_submission, admin_communitylibrary_submission, saved-search.
  • ChannelUserViewSet: GET /api/channeluser/<id> without ?channel= raises FieldError: Cannot resolve keyword 'can_edit'. can_edit and can_view exist only once the channel filter has annotated them.
  • ContentNodeTreeViewset.validate_and_return_params: depth=3, depth=abc, next__gt=-1 and next__gt=abc raise Django ValidationError on the anonymous public tree endpoint. Kolibri has the same code (learningequality/kolibri#15835).
  • resolve calls CommunityLibrarySubmission.save, which raises Django ValidationError when the author is no longer a channel editor or the channel has since become public.
The Change
  • serialize_object should follow Kolibri's fix and also treat Django ValidationError as not found.
  • channeluser retrieve without ?channel= should respond as the list route does. Each other site should return 400 instead of 500.
  • The custom EXCEPTION_HANDLER from the strategy in #6387 lands in this issue.
Acceptance Criteria
General
  • Each detail route listed in Context returns 404 for a malformed pk.
  • channeluser retrieve without ?channel= gets the same response as the list route without ?channel=.
  • Invalid depth and next__gt values return 400.
  • resolve returns 400 with the validation message for the two submission states in Context.
  • Django ValidationError raised in any DRF view returns 400, and ObjectDoesNotExist returns 404.
Testing
  • Each input in Context has a regression test.

AI usage

I scoped the audit and chose the validation strategy in #6387. Claude Code found and reproduced these failures and drafted this issue.

主要语言
Python
星标
212
派生
321
平均合并
1 天 7 小时
30 天内合并 PR
14

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

learningequality/studio 的其他 Issue

查看 learningequality/studio 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。