Django exceptions reach DRF as 500

Aperta
#6,391 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
django, python

Direzione di ricerca

Start with contentcuration/contentcuration/viewsets/base.py and the serialize_object behavior linked in the issue, then read the related DRF views and the exception handler strategy in #6387. Add regression tests for each input listed in Context and verify malformed detail-route pks return 404, invalid parameters and submission states return 400, and Django ObjectDoesNotExist returns 404.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

DEV: backend

Overview

Some code raises Django's ValidationError, ObjectDoesNotExist or FieldError inside DRF views. DRF converts only its own exceptions, Http404 and PermissionDenied, so these return 500. BaseValuesViewset.serialize_object also crashes on some malformed pks before it can return its 404.

Complexity: Medium
Target branch: hotfixes

Context

All inputs below were reproduced:

  • BaseValuesViewset.serialize_object:
    • On a model with an integer pk, GET /api/assessmentitem/abc raises UnboundLocalError, because .filter() fails before queryset is assigned. Kolibri fixed this in learningequality/kolibri@eeb4c8207e.
    • On SavedSearch, whose pk is a Django UUIDField, GET /api/search/saved-search/abc raises Django ValidationError, which isn't in the caught tuple.
    • Affected detail routes: assessmentitem, user, admin-users, bookmark, channeluser, communitylibrary_submission, admin_communitylibrary_submission, saved-search.
  • ChannelUserViewSet: GET /api/channeluser/<id> without ?channel= raises FieldError: Cannot resolve keyword 'can_edit'. can_edit and can_view exist only once the channel filter has annotated them.
  • ContentNodeTreeViewset.validate_and_return_params: depth=3, depth=abc, next__gt=-1 and next__gt=abc raise Django ValidationError on the anonymous public tree endpoint. Kolibri has the same code (learningequality/kolibri#15835).
  • resolve calls CommunityLibrarySubmission.save, which raises Django ValidationError when the author is no longer a channel editor or the channel has since become public.
The Change
  • serialize_object should follow Kolibri's fix and also treat Django ValidationError as not found.
  • channeluser retrieve without ?channel= should respond as the list route does. Each other site should return 400 instead of 500.
  • The custom EXCEPTION_HANDLER from the strategy in #6387 lands in this issue.
Acceptance Criteria
General
  • Each detail route listed in Context returns 404 for a malformed pk.
  • channeluser retrieve without ?channel= gets the same response as the list route without ?channel=.
  • Invalid depth and next__gt values return 400.
  • resolve returns 400 with the validation message for the two submission states in Context.
  • Django ValidationError raised in any DRF view returns 400, and ObjectDoesNotExist returns 404.
Testing
  • Each input in Context has a regression test.

AI usage

I scoped the audit and chose the validation strategy in #6387. Claude Code found and reproduced these failures and drafted this issue.

Lingua principale
Python
Stelle
212
Fork
321
Merge medio
1g 7h
PR unite (30g)
14

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di learningequality/studio

Tutte le issue di learningequality/studio

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.