v1: hero buttons should skip past #navigate to the first content section
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
首先检查所列 HTML 页面中的 hero-button 标记和目标部分，然后阅读 assets/js/main.js 以了解 scrollex 触发器的行为。更新每个所列页面，使其指向指定的第一个内容部分，重新查看 sitemap.html 的按钮标签，并验证在桌面宽度和 360px 下点击后动画部分都会出现。
由索引模型根据 Issue 内容生成。
描述
On every v1 content page, the hero button ("Tell Me More...", or "Read T&Cs" on the terms page) smooth-scrolls to #navigate, the grid of Navigate buttons. It should skip past that grid to the page's first real content section.
Why
The content sections animate in via scrollex in assets/js/main.js. .items and .gallery blocks (and the $wrapper.children() sections) have top: '30vh', bottom: '30vh', so they only lose is-inactive once they reach the middle band of the viewport. When the hero button lands on #navigate, the next section sits too low to trigger. Its content stays hidden until you scroll a little further by hand, which is the annoying bit. Landing on the content section itself should put it inside the trigger band straight away.
The Navigate grid stays where it is and is still reachable by scrolling up. Only the hero button's target changes.
Scope
None of these pages has a #pages anchor (only sitemap.html does), so each page needs its own target: the first section after #navigate.
| Page | Current | Proposed target |
|---|---|---|
bellringing.html |
#navigate |
#what-is-it |
cars.html |
#navigate |
#mx5 |
coffee.html |
#navigate |
#specialty |
engineer.html |
#navigate |
#explore |
engineer-ai.html |
#navigate |
#cyber-range |
engineer-devops.html |
#navigate |
#iac |
engineer-firmware.html |
#navigate |
#firmware |
leader.html |
#navigate |
#numbers |
photographer.html |
#navigate |
#event |
prod_tech.html |
#navigate |
#sound-engineer |
sitemap.html |
#navigate |
#pages |
terms-and-conditions.html |
#navigate |
#terms |
Out of scope: index.html already targets its first content section (#first), and travel.html / under_construction.html have no hero button.
Open question
Should the per-page anchors stay as they are, or should every page's first content section get a shared id (e.g. #content) so every hero button carries the same href? A shared id makes the pages uniform and future pages easier, but it means renaming ids that may already be deep-linked.
Acceptance
- Every hero button above targets the page's first content section.
- On each page, clicking the hero button reveals that section's animated content with no extra manual scroll, at desktop and at the 360px floor.
-
sitemap.html's button label is revisited once it targets#pages("Jump to Pages" becomes accurate again).
Follows from review on #68.
- 主要语言
- HTML
- 星标
- 0
- 派生
- 0
- 平均合并
- 9 小时 52 分钟
- 30 天内合并 PR
- 59
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
laywill/laywill.github.io 的其他 Issue
-
design
难度 2/5 1-3 小时 新手友好度 75/100
laywill/laywill.github.io#186 ·
维护者通常 1 天内回复
-
design
难度 2/5 1-3 小时 新手友好度 68/100
laywill/laywill.github.io#183 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 半天 新手友好度 74/100
laywill/laywill.github.io#135 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
laywill/laywill.github.io#106 ·
维护者通常 1 天内回复
-
infra needs-william
难度 2/5 1-3 小时 新手友好度 82/100
laywill/laywill.github.io#35 · 1 条评论 ·
维护者通常 1 天内回复
查看 laywill/laywill.github.io 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 80/100
keyxmakerx/Chronicle#1179 ·
维护者通常 1 天内回复
-
area:studio type:security
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
bug priority:medium
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 1 天内回复
-
Database: Person property settings, open Limit / Default / Notify as flyouts (NavigableMenuItem)未关闭database enhancement good first issue low small
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复