v1: hero buttons should skip past #navigate to the first content section
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 74/100
Línea de trabajo
Comienza comprobando el marcado de hero-button y las secciones de destino en las páginas HTML indicadas; después, lee assets/js/main.js para entender el comportamiento del disparador de scrollex. Actualiza cada página indicada para que apunte a su primera sección de contenido especificada, revisa la etiqueta del botón de sitemap.html y verifica que la sección animada aparezca después de hacer clic tanto con el ancho de escritorio como con 360px.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
On every v1 content page, the hero button ("Tell Me More...", or "Read T&Cs" on the terms page) smooth-scrolls to #navigate, the grid of Navigate buttons. It should skip past that grid to the page's first real content section.
Why
The content sections animate in via scrollex in assets/js/main.js. .items and .gallery blocks (and the $wrapper.children() sections) have top: '30vh', bottom: '30vh', so they only lose is-inactive once they reach the middle band of the viewport. When the hero button lands on #navigate, the next section sits too low to trigger. Its content stays hidden until you scroll a little further by hand, which is the annoying bit. Landing on the content section itself should put it inside the trigger band straight away.
The Navigate grid stays where it is and is still reachable by scrolling up. Only the hero button's target changes.
Scope
None of these pages has a #pages anchor (only sitemap.html does), so each page needs its own target: the first section after #navigate.
| Page | Current | Proposed target |
|---|---|---|
bellringing.html |
#navigate |
#what-is-it |
cars.html |
#navigate |
#mx5 |
coffee.html |
#navigate |
#specialty |
engineer.html |
#navigate |
#explore |
engineer-ai.html |
#navigate |
#cyber-range |
engineer-devops.html |
#navigate |
#iac |
engineer-firmware.html |
#navigate |
#firmware |
leader.html |
#navigate |
#numbers |
photographer.html |
#navigate |
#event |
prod_tech.html |
#navigate |
#sound-engineer |
sitemap.html |
#navigate |
#pages |
terms-and-conditions.html |
#navigate |
#terms |
Out of scope: index.html already targets its first content section (#first), and travel.html / under_construction.html have no hero button.
Open question
Should the per-page anchors stay as they are, or should every page's first content section get a shared id (e.g. #content) so every hero button carries the same href? A shared id makes the pages uniform and future pages easier, but it means renaming ids that may already be deep-linked.
Acceptance
- Every hero button above targets the page's first content section.
- On each page, clicking the hero button reveals that section's animated content with no extra manual scroll, at desktop and at the 360px floor.
-
sitemap.html's button label is revisited once it targets#pages("Jump to Pages" becomes accurate again).
Follows from review on #68.
- Lenguaje dominante
- HTML
- Estrellas
- 0
- Forks
- 0
- Merge medio
- 8 h 17 min
- PR fusionados (30 d)
- 58
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de laywill/laywill.github.io
-
design
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
laywill/laywill.github.io#186 ·
-
design
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
laywill/laywill.github.io#183 · 1 comentario ·
-
Dificultad 2/5 Medio día Aptitud para principiantes 74/100
laywill/laywill.github.io#135 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
laywill/laywill.github.io#106 ·
-
infra needs-william
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
laywill/laywill.github.io#35 · 1 comentario ·
Todos los issues de laywill/laywill.github.io
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
pastelsky/bundlephobia#1122 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
speaches-ai/speaches#678 ·
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Dificultad 1/5 Menos de una hora Aptitud para principiantes 95/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
jellyfin/jellyfin-web#8540 ·