columns: a corrupt parent state is re-read once per sidecar of a group since #788 met #754
维护者通常 6 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 78/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- rust
- 领域
- backend, documentation, testing
调研方向
Start with ChainPrechecks::judge_header in crates/blockchain/state_transition/src/beacon/gossip/column.rs and the StateRebuilds documentation in crates/storage/src/state_writer.rs. Add a test showing that a corrupt parent state is read once for a multi sidecar group, while other read errors still retry. Update the reason="internal" description for lean_data_columns_rejected_total in docs/metrics.md, then run the relevant state transition tests.
由索引模型根据 Issue 内容生成。
描述
Problem. Merging main into lambdaclass/ethlambda#788 put the PR's "a failed parent-state read drops the sidecar" rule inside main's grouped column prechecks (#754). There, ChainPrechecks::judge_header (crates/blockchain/state_transition/src/beacon/gossip/column.rs) does not remember an Err from get_state. That is deliberate, so that one transient read error does not drop the whole block: the group's next sidecar reads the state again.
For a corrupt parent state, though, every one of those reads fails. A group then re-reads it once per sidecar, one after another on the group's permit, up to the block's 128 columns. Each attempt is a full failed rebuild (about a second of CPU, by the StateRebuilds doc in crates/storage/src/state_writer.rs) plus an error! line. That works against #788's own rule that a corrupt root is read once and shared (Error::CorruptState). Verdicts are unaffected: every sidecar is dropped as Ignore(Internal) either way. Only on-disk corruption triggers it.
A related doc gap: the lean_data_columns_rejected_total section of docs/metrics.md still says reason="internal" counts the sidecars that a panic in the checks cost. Since the merge, it also counts sidecars dropped for a failed parent-state read.
Why it is a follow-up. #788 is approved and in the merge queue. The re-read only costs CPU on a node whose store is already corrupt.
Fix.
- In
judge_header, remember the drop for the block's parent when the error isethlambda_storage::Error::CorruptState, so the rest of the group is dropped without reading again. Keep reading again on any otherErr. - Add a test: a corrupt parent state is read once for a multi-sidecar group.
- Add the failed-read case to the
reason="internal"text indocs/metrics.md.
- 主要语言
- Rust
- 星标
- 86
- 派生
- 34
- 平均合并
- 9 天 20 小时
- 30 天内合并 PR
- 77
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
lambdaclass/ethlambda 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
lambdaclass/ethlambda#850 ·
维护者通常 6 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
lambdaclass/ethlambda#777 · 1 个 reaction ·
维护者通常 6 天内回复
-
Run all gossip validation tests可能重新可做 @dicethedev 于 9 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 62/100
lambdaclass/ethlambda#725 · 2 条评论 ·
维护者通常 6 天内回复
-
Handle malformed DB data可能重新可做 @dicethedev 于 115 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
lambdaclass/ethlambda#529 · 4 条评论 ·
维护者通常 6 天内回复
-
Document architectural choices可能重新可做 @dicethedev 于 115 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
lambdaclass/ethlambda#521 · 2 条评论 ·
维护者通常 6 天内回复
查看 lambdaclass/ethlambda 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 88/100
bytecodealliance/wrpc#1785 ·
维护者通常 1 天内回复
-
2 advisory ignore entries no longer match anything (`quick-xml` already patched in `Cargo.lock`)未关闭
难度 1/5 1 小时以内 新手友好度 85/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
longbridge/nsh#2758 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
antithesishq/bombadil#473 ·
维护者通常 2 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
libracoder/kiri#669 ·
维护者通常 1 天内回复