columns: a corrupt parent state is re-read once per sidecar of a group since #788 met #754

未关闭
#839 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 6 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
78/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
rust

调研方向

Start with ChainPrechecks::judge_header in crates/blockchain/state_transition/src/beacon/gossip/column.rs and the StateRebuilds documentation in crates/storage/src/state_writer.rs. Add a test showing that a corrupt parent state is read once for a multi sidecar group, while other read errors still retry. Update the reason="internal" description for lean_data_columns_rejected_total in docs/metrics.md, then run the relevant state transition tests.

由索引模型根据 Issue 内容生成。

描述

Problem. Merging main into lambdaclass/ethlambda#788 put the PR's "a failed parent-state read drops the sidecar" rule inside main's grouped column prechecks (#754). There, ChainPrechecks::judge_header (crates/blockchain/state_transition/src/beacon/gossip/column.rs) does not remember an Err from get_state. That is deliberate, so that one transient read error does not drop the whole block: the group's next sidecar reads the state again.

For a corrupt parent state, though, every one of those reads fails. A group then re-reads it once per sidecar, one after another on the group's permit, up to the block's 128 columns. Each attempt is a full failed rebuild (about a second of CPU, by the StateRebuilds doc in crates/storage/src/state_writer.rs) plus an error! line. That works against #788's own rule that a corrupt root is read once and shared (Error::CorruptState). Verdicts are unaffected: every sidecar is dropped as Ignore(Internal) either way. Only on-disk corruption triggers it.

A related doc gap: the lean_data_columns_rejected_total section of docs/metrics.md still says reason="internal" counts the sidecars that a panic in the checks cost. Since the merge, it also counts sidecars dropped for a failed parent-state read.

Why it is a follow-up. #788 is approved and in the merge queue. The re-read only costs CPU on a node whose store is already corrupt.

Fix.

  • In judge_header, remember the drop for the block's parent when the error is ethlambda_storage::Error::CorruptState, so the rest of the group is dropped without reading again. Keep reading again on any other Err.
  • Add a test: a corrupt parent state is read once for a multi-sidecar group.
  • Add the failed-read case to the reason="internal" text in docs/metrics.md.
主要语言
Rust
星标
86
派生
34
平均合并
9 天 20 小时
30 天内合并 PR
77

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

lambdaclass/ethlambda 的其他 Issue

查看 lambdaclass/ethlambda 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。