columns: a corrupt parent state is re-read once per sidecar of a group since #788 met #754

Aberta
#839 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 6 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
78/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
rust

Direção de pesquisa

Start with ChainPrechecks::judge_header in crates/blockchain/state_transition/src/beacon/gossip/column.rs and the StateRebuilds documentation in crates/storage/src/state_writer.rs. Add a test showing that a corrupt parent state is read once for a multi sidecar group, while other read errors still retry. Update the reason="internal" description for lean_data_columns_rejected_total in docs/metrics.md, then run the relevant state transition tests.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Problem. Merging main into lambdaclass/ethlambda#788 put the PR's "a failed parent-state read drops the sidecar" rule inside main's grouped column prechecks (#754). There, ChainPrechecks::judge_header (crates/blockchain/state_transition/src/beacon/gossip/column.rs) does not remember an Err from get_state. That is deliberate, so that one transient read error does not drop the whole block: the group's next sidecar reads the state again.

For a corrupt parent state, though, every one of those reads fails. A group then re-reads it once per sidecar, one after another on the group's permit, up to the block's 128 columns. Each attempt is a full failed rebuild (about a second of CPU, by the StateRebuilds doc in crates/storage/src/state_writer.rs) plus an error! line. That works against #788's own rule that a corrupt root is read once and shared (Error::CorruptState). Verdicts are unaffected: every sidecar is dropped as Ignore(Internal) either way. Only on-disk corruption triggers it.

A related doc gap: the lean_data_columns_rejected_total section of docs/metrics.md still says reason="internal" counts the sidecars that a panic in the checks cost. Since the merge, it also counts sidecars dropped for a failed parent-state read.

Why it is a follow-up. #788 is approved and in the merge queue. The re-read only costs CPU on a node whose store is already corrupt.

Fix.

  • In judge_header, remember the drop for the block's parent when the error is ethlambda_storage::Error::CorruptState, so the rest of the group is dropped without reading again. Keep reading again on any other Err.
  • Add a test: a corrupt parent state is read once for a multi-sidecar group.
  • Add the failed-read case to the reason="internal" text in docs/metrics.md.
Linguagem predominante
Rust
Estrelas
86
Forks
34
Merge médio
9d 20h
PRs com merge (30d)
77

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de lambdaclass/ethlambda

Todas as issues de lambdaclass/ethlambda

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.