t8n: sender/signature mismatch is accepted (JSON sender trusted over v/r/s)
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 38/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- cpp
- 领域
- backend, blockchain
调研方向
Start by reading test/utils/statetest_loader.cpp and test/state/state.cpp, where the issue says sender is loaded and used for checks and execution. Run the supplied evmone-t8n and evm t8n commands with the reproducer to compare behavior. Done means transactions with a mismatched or malformed signature are handled consistently with the intended sender validation.
由索引模型根据 Issue 内容生成。
描述
Summary
evmone-t8n accepts transactions based on the JSON sender field without validating that (v,r,s) recovers to the same sender.
This creates a cross-client divergence with geth evm t8n: a tx signed by account A can be executed as account B in evmone-t8n if JSON sets sender=B.
Why this matters
In t8n/state-transition semantics, sender should be derived from signature and chain rules (or at least validated against provided sender).
Current behavior lets malformed tx JSON produce wrong state roots and acceptance/rejection results.
Reproducer
alloc.json
{
"0x1111111111111111111111111111111111111111": {
"code": "0x",
"nonce": "0x0",
"balance": "0xde0b6b3a7640000",
"storage": {}
}
}
env.json
{
"currentCoinbase": "0x8888f1f195afa192cfee860698584c030f4c9db1",
"currentNumber": "0x01",
"currentTimestamp": "0x54c99069",
"currentGasLimit": "0x2fefd8",
"currentRandom": "0x0000000000000000000000000000000000000000000000000000000000000001",
"parentBeaconBlockRoot": "0x0000000000000000000000000000000000000000000000000000000000000000",
"currentBaseFee": "0x1",
"currentExcessBlobGas": "0x0",
"withdrawals": []
}
txs.json
v,r,s below are from a tx signed by 0xa94f5374... (not by 0x1111...).
[
{
"to": "0x095E7BAea6a6c7c4c2DfeB977eFac326aF552d87",
"input": "0x",
"gas": "0x5208",
"nonce": "0x0",
"value": "0x0",
"gasPrice": "0x1",
"chainId": "0x1",
"sender": "0x1111111111111111111111111111111111111111",
"v": "0x26",
"r": "0x62d32a1bac6b89021fce16cf51479a8b00f26523933afde1b62f7957ed1943a3",
"s": "0x6f3941435cb48b0c649c1b0d707fc6878407f6287c9cd89c33c0048bd2710e45"
}
]
Commands
evmone-t8n \
--state.fork Cancun --state.reward 0 --state.chainid 1 \
--input.alloc alloc.json --input.env env.json --input.txs txs.json \
--output.basedir out-evmone --output.result out.json --output.alloc outAlloc.json
evm t8n \
--state.fork Cancun --state.reward 0 --state.chainid 1 \
--input.alloc alloc.json --input.env env.json --input.txs txs.json \
--output.basedir out-geth --output.result out.json --output.alloc outAlloc.json
Observed
evmone-t8n:rejected: []gasUsed: 0x5208- executes transaction and updates state.
- geth
evm t8n:- rejects tx:
insufficient funds ... address 0xa94f5374... have 0 want 21000
gasUsed: 0x0- no executed tx in block result.
- rejects tx:
Suspected root cause
sender is loaded from JSON and used directly for state checks/execution:
test/utils/statetest_loader.cppo.sender = load_if_exists<evmc::address>(j, "sender");- parses
v/r/sbut does not recover/validate sender from signature.
test/state/state.cpp- validation and balance checks use
tx.senderdirectly.
- validation and balance checks use
So (v,r,s) authenticity is effectively not enforced for tx sender in evmone-t8n.
Suggested fix direction
Recover sender from signature (per tx type / chain id / fork rules) and either:
- Use recovered sender as authoritative, or
- Reject when provided
senderdisagrees with recovered sender.
Also reject malformed signatures consistently with other clients.
- 主要语言
- C++
- 星标
- 979
- 派生
- 340
- 平均合并
- 12 小时 16 分钟
- 30 天内合并 PR
- 25
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
ipsilon/evmone 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 82/100
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 56/100
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 57/100
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 12/100
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 52/100
维护者通常 1 天内回复
相似的 Issue
-
难度 1/5 1-3 小时 新手友好度 77/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
phantoslayer21/wronggpu#275 ·
维护者通常 1 天内回复
-
bug good first issue
难度 2/5 1-3 小时 新手友好度 75/100
ReyeMe/SaturnRingLib#155 ·
-
bug
难度 2/5 1-3 小时 新手友好度 62/100
Nheko-Reborn/nheko#2092 ·
-
难度 1/5 1-3 小时 新手友好度 78/100
isocpp/CppCoreGuidelines#2345 ·