t8n: sender/signature mismatch is accepted (JSON sender trusted over v/r/s)
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 38/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Estancado
- Stack tecnológico
- cpp
- Área
- backend, blockchain
Línea de trabajo
Start by reading test/utils/statetest_loader.cpp and test/state/state.cpp, where the issue says sender is loaded and used for checks and execution. Run the supplied evmone-t8n and evm t8n commands with the reproducer to compare behavior. Done means transactions with a mismatched or malformed signature are handled consistently with the intended sender validation.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
evmone-t8n accepts transactions based on the JSON sender field without validating that (v,r,s) recovers to the same sender.
This creates a cross-client divergence with geth evm t8n: a tx signed by account A can be executed as account B in evmone-t8n if JSON sets sender=B.
Why this matters
In t8n/state-transition semantics, sender should be derived from signature and chain rules (or at least validated against provided sender).
Current behavior lets malformed tx JSON produce wrong state roots and acceptance/rejection results.
Reproducer
alloc.json
{
"0x1111111111111111111111111111111111111111": {
"code": "0x",
"nonce": "0x0",
"balance": "0xde0b6b3a7640000",
"storage": {}
}
}
env.json
{
"currentCoinbase": "0x8888f1f195afa192cfee860698584c030f4c9db1",
"currentNumber": "0x01",
"currentTimestamp": "0x54c99069",
"currentGasLimit": "0x2fefd8",
"currentRandom": "0x0000000000000000000000000000000000000000000000000000000000000001",
"parentBeaconBlockRoot": "0x0000000000000000000000000000000000000000000000000000000000000000",
"currentBaseFee": "0x1",
"currentExcessBlobGas": "0x0",
"withdrawals": []
}
txs.json
v,r,s below are from a tx signed by 0xa94f5374... (not by 0x1111...).
[
{
"to": "0x095E7BAea6a6c7c4c2DfeB977eFac326aF552d87",
"input": "0x",
"gas": "0x5208",
"nonce": "0x0",
"value": "0x0",
"gasPrice": "0x1",
"chainId": "0x1",
"sender": "0x1111111111111111111111111111111111111111",
"v": "0x26",
"r": "0x62d32a1bac6b89021fce16cf51479a8b00f26523933afde1b62f7957ed1943a3",
"s": "0x6f3941435cb48b0c649c1b0d707fc6878407f6287c9cd89c33c0048bd2710e45"
}
]
Commands
evmone-t8n \
--state.fork Cancun --state.reward 0 --state.chainid 1 \
--input.alloc alloc.json --input.env env.json --input.txs txs.json \
--output.basedir out-evmone --output.result out.json --output.alloc outAlloc.json
evm t8n \
--state.fork Cancun --state.reward 0 --state.chainid 1 \
--input.alloc alloc.json --input.env env.json --input.txs txs.json \
--output.basedir out-geth --output.result out.json --output.alloc outAlloc.json
Observed
evmone-t8n:rejected: []gasUsed: 0x5208- executes transaction and updates state.
- geth
evm t8n:- rejects tx:
insufficient funds ... address 0xa94f5374... have 0 want 21000
gasUsed: 0x0- no executed tx in block result.
- rejects tx:
Suspected root cause
sender is loaded from JSON and used directly for state checks/execution:
test/utils/statetest_loader.cppo.sender = load_if_exists<evmc::address>(j, "sender");- parses
v/r/sbut does not recover/validate sender from signature.
test/state/state.cpp- validation and balance checks use
tx.senderdirectly.
- validation and balance checks use
So (v,r,s) authenticity is effectively not enforced for tx sender in evmone-t8n.
Suggested fix direction
Recover sender from signature (per tx type / chain id / fork rules) and either:
- Use recovered sender as authoritative, or
- Reject when provided
senderdisagrees with recovered sender.
Also reject malformed signatures consistently with other clients.
- Lenguaje dominante
- C++
- Estrellas
- 979
- Forks
- 340
- Merge medio
- 12 h 16 min
- PR fusionados (30 d)
- 25
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Sin plantilla de pull request
- Sin guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de ipsilon/evmone
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
Dificultad 3/5 1-2 días Aptitud para principiantes 56/100
Los mantenedores suelen responder en 1 día
-
Dificultad 3/5 1-2 días Aptitud para principiantes 57/100
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 12/100
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 52/100
Los mantenedores suelen responder en 1 día
Todos los issues de ipsilon/evmone
Issues similares
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
phantoslayer21/wronggpu#275 ·
Los mantenedores suelen responder en 1 día
-
bug good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
ReyeMe/SaturnRingLib#155 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
Nheko-Reborn/nheko#2092 ·
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 78/100
isocpp/CppCoreGuidelines#2345 ·