Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

History log "committed" column is inaccurate

未关闭
  • 哪里不对？
#1,237 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
xml
领域
backend, cli

调研方向

从 src/cls/IPM/General/AbstractHistory.cls:124 的 %IPM.General.AbstractHistory:Finalize() 开始，跟踪 %IPM.Utils.Module:LoadModuleFromDirectory() 中大约第 1137-1315 行的事务设置、开发者模式解析、提交和回滚路径。分别复现使用 -dev 加载格式错误的 module.xml，以及使用 -DNoTransaction=1 进行安装；完成标准是 Committed 与更改是否实际保留相一致。

由索引模型根据 Issue 内容生成。

描述

bug

Describe the bug

The Committed column on history records does not reliably indicate whether an action's changes survived. It is computed from the action's status and whether developer mode was on, rather than from what actually happened to the transaction:

%IPM.General.AbstractHistory:Finalize() (src/cls/IPM/General/AbstractHistory.cls:124):

set ..Committed = (dev = 1) || $$$ISOK(status)

This is wrong in both directions.

Dev-mode failures are always marked committed, even when fully rolled back.

In %IPM.Utils.Module:LoadModuleFromDirectory(), the transaction opens at line 1160 and the first developer-mode tcommit is at line 1272. tDeveloperMode is not even resolved until line 1259. Everything in that window runs inside a transaction that the catch block rolls back at lines 1313-1315, regardless of developer mode.

So a -dev action that fails before line 1272 (for example a malformed module.xml rejected in GetModuleObjectFromPath) is rolled back in full, but its history record still reads Committed.

The intended dev-mode behavior for phases after line 1272 is correct and is not at issue here. The early-failure window is.

Non-transactional failures are marked uncommitted despite keeping their changes.

tUseTransactions is false when -DNoTransaction=1 or -DNoJournal=1 is passed (line 1137). No transaction is opened, so a failure leaves partial changes in the namespace. Because the status is an error and developer mode is off, the record reads Uncommitted.

To Reproduce

Rolled-back action reported as committed:

  1. load /path/to/malformed-module -dev where the directory contains a module.xml with a syntax error
  2. history find -limit 5
  3. The record shows an error in Success and Committed in Committed, even though the transaction was rolled back and nothing was written

Retained changes reported as uncommitted:

  1. install some-module -DNoTransaction=1 with a module whose Activate phase fails
  2. history find -limit 5
  3. The record reads Uncommitted, but partial changes remain in the namespace

Expected behavior

Committed should reflect whether the action's changes were actually retained.

Options, roughly in increasing order of effort:

  1. Compare $tlevel against the level captured at entry, or have the rollback path signal that it ran, and pass that to Finalize() instead of inferring from dev.
  2. Set Committed at each commit point rather than once at the end, so the flag tracks how far the action actually got.
  3. If the current value is intentional as a coarse signal, rename it or document it as "changes may have been retained" and stop treating dev = 1 as sufficient.

Option 1 is the smallest change that fixes both directions, since it makes the flag observed rather than derived.

System information

  • IPM version: 0.10.5+
主要语言
ObjectScript
星标
41
派生
30
平均合并
4 天 10 小时
30 天内合并 PR
10

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

intersystems/ipm 的其他 Issue

查看 intersystems/ipm 的全部 Issue

相似的 Issue

更多 Backend & API Design Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。