Hacktoberfest 2026:メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

History log "committed" column is inaccurate

オープン
#1,237 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
55/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
xml
領域
backend, cli

調査の方向性

src/cls/IPM/General/AbstractHistory.cls:124 の %IPM.General.AbstractHistory:Finalize() から開始し、1137-1315 行付近の %IPM.Utils.Module:LoadModuleFromDirectory() におけるトランザクション設定、開発者モードの解決、commit、rollback の経路を追跡します。-dev を指定した不正な module.xml の読み込みと、-DNoTransaction=1 を指定したインストールの両方を再現します。完了条件は、変更が実際に保持されたかどうかと Committed が一致することです。

索引モデルが issue の本文から書いたものです。

説明

bug

Describe the bug

The Committed column on history records does not reliably indicate whether an action's changes survived. It is computed from the action's status and whether developer mode was on, rather than from what actually happened to the transaction:

%IPM.General.AbstractHistory:Finalize() (src/cls/IPM/General/AbstractHistory.cls:124):

set ..Committed = (dev = 1) || $$$ISOK(status)

This is wrong in both directions.

Dev-mode failures are always marked committed, even when fully rolled back.

In %IPM.Utils.Module:LoadModuleFromDirectory(), the transaction opens at line 1160 and the first developer-mode tcommit is at line 1272. tDeveloperMode is not even resolved until line 1259. Everything in that window runs inside a transaction that the catch block rolls back at lines 1313-1315, regardless of developer mode.

So a -dev action that fails before line 1272 (for example a malformed module.xml rejected in GetModuleObjectFromPath) is rolled back in full, but its history record still reads Committed.

The intended dev-mode behavior for phases after line 1272 is correct and is not at issue here. The early-failure window is.

Non-transactional failures are marked uncommitted despite keeping their changes.

tUseTransactions is false when -DNoTransaction=1 or -DNoJournal=1 is passed (line 1137). No transaction is opened, so a failure leaves partial changes in the namespace. Because the status is an error and developer mode is off, the record reads Uncommitted.

To Reproduce

Rolled-back action reported as committed:

  1. load /path/to/malformed-module -dev where the directory contains a module.xml with a syntax error
  2. history find -limit 5
  3. The record shows an error in Success and Committed in Committed, even though the transaction was rolled back and nothing was written

Retained changes reported as uncommitted:

  1. install some-module -DNoTransaction=1 with a module whose Activate phase fails
  2. history find -limit 5
  3. The record reads Uncommitted, but partial changes remain in the namespace

Expected behavior

Committed should reflect whether the action's changes were actually retained.

Options, roughly in increasing order of effort:

  1. Compare $tlevel against the level captured at entry, or have the rollback path signal that it ran, and pass that to Finalize() instead of inferring from dev.
  2. Set Committed at each commit point rather than once at the end, so the flag tracks how far the action actually got.
  3. If the current value is intentional as a coarse signal, rename it or document it as "changes may have been retained" and stop treating dev = 1 as sufficient.

Option 1 is the smallest change that fixes both directions, since it makes the flag observed rather than derived.

System information

  • IPM version: 0.10.5+
主要言語
ObjectScript
スター
41
フォーク
29
平均マージ
7日 8時間
マージ済み PR(30日)
4

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

intersystems/ipm のほかの issue

intersystems/ipm の issue をすべて見る

似ている issue

Backend & API Design の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。