History log "committed" column is inaccurate
まだ誰も着手していません。
評価
調査の方向性
src/cls/IPM/General/AbstractHistory.cls:124 の %IPM.General.AbstractHistory:Finalize() から開始し、1137-1315 行付近の %IPM.Utils.Module:LoadModuleFromDirectory() におけるトランザクション設定、開発者モードの解決、commit、rollback の経路を追跡します。-dev を指定した不正な module.xml の読み込みと、-DNoTransaction=1 を指定したインストールの両方を再現します。完了条件は、変更が実際に保持されたかどうかと Committed が一致することです。
索引モデルが issue の本文から書いたものです。
説明
Describe the bug
The Committed column on history records does not reliably indicate whether an action's changes survived. It is computed from the action's status and whether developer mode was on, rather than from what actually happened to the transaction:
%IPM.General.AbstractHistory:Finalize() (src/cls/IPM/General/AbstractHistory.cls:124):
set ..Committed = (dev = 1) || $$$ISOK(status)
This is wrong in both directions.
Dev-mode failures are always marked committed, even when fully rolled back.
In %IPM.Utils.Module:LoadModuleFromDirectory(), the transaction opens at line 1160 and the first developer-mode tcommit is at line 1272. tDeveloperMode is not even resolved until line 1259. Everything in that window runs inside a transaction that the catch block rolls back at lines 1313-1315, regardless of developer mode.
So a -dev action that fails before line 1272 (for example a malformed module.xml rejected in GetModuleObjectFromPath) is rolled back in full, but its history record still reads Committed.
The intended dev-mode behavior for phases after line 1272 is correct and is not at issue here. The early-failure window is.
Non-transactional failures are marked uncommitted despite keeping their changes.
tUseTransactions is false when -DNoTransaction=1 or -DNoJournal=1 is passed (line 1137). No transaction is opened, so a failure leaves partial changes in the namespace. Because the status is an error and developer mode is off, the record reads Uncommitted.
To Reproduce
Rolled-back action reported as committed:
load /path/to/malformed-module -devwhere the directory contains amodule.xmlwith a syntax errorhistory find -limit 5- The record shows an error in
SuccessandCommittedinCommitted, even though the transaction was rolled back and nothing was written
Retained changes reported as uncommitted:
install some-module -DNoTransaction=1with a module whoseActivatephase failshistory find -limit 5- The record reads
Uncommitted, but partial changes remain in the namespace
Expected behavior
Committed should reflect whether the action's changes were actually retained.
Options, roughly in increasing order of effort:
- Compare
$tlevelagainst the level captured at entry, or have the rollback path signal that it ran, and pass that toFinalize()instead of inferring fromdev. - Set
Committedat each commit point rather than once at the end, so the flag tracks how far the action actually got. - If the current value is intentional as a coarse signal, rename it or document it as "changes may have been retained" and stop treating
dev = 1as sufficient.
Option 1 is the smallest change that fixes both directions, since it makes the flag observed rather than derived.
System information
- IPM version: 0.10.5+
- 主要言語
- ObjectScript
- スター
- 41
- フォーク
- 29
- 平均マージ
- 7日 8時間
- マージ済み PR(30日)
- 4
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
intersystems/ipm のほかの issue
-
bug technical debt
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
intersystems/ipm#1251 ·
-
The "MarkedForUpdate" property on %IPM.Storage.ResourceReference should have XMLPROJECTION = "NONE" オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
intersystems/ipm#1248 ·
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
intersystems/ipm#1241 ·
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
intersystems/ipm#1236 ·
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
intersystems/ipm#1204 ·
intersystems/ipm の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 80/100
microsoft/magentic-ui#588 ·
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
alexgorbatchev/simple-ptt#3 · コメント 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
CorrelAid/formtransform#44 ·