Repro mode cannot be resumed or repeated: repro state is never reset

未关闭
#405 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
rust

调研方向

Start with the repro state and stop handling in src/lib.rs, src/haps/mod.rs, and src/interfaces/fuzz.rs, then trace how repro interacts with snapshots and the fuzzer thread. Reproduce the reported cases under SIMICS, including resuming after a repro stop and calling repro twice. Done when repro state can be reset, repro runs stop correctly, and fuzzing can resume without treating the repro result as pending input.

由索引模型根据 Issue 内容生成。

描述

Where

Problem
repro_testcase, repro_bookmark_set and stopped_for_repro are only ever set. Also, repro() after fuzzing (iterations > 0) restores, writes and continues, but never arms the repro stop (repro_bookmark_set is only set by the start handlers, which do not run again after a restore).

Impact
After one repro stop, on_simulation_stopped returns early forever, so fuzzing cannot resume. A second repro(file2) before fuzzing only swaps bytes. repro() after fuzzing likely sends the repro result to the fuzzer as if it were its pending input and keeps looping. fuzz_thread is a OnceCell, so a stopped fuzzer cannot be restarted.

Suggested fix
Clear stopped_for_repro at the top of repro(), arm the repro stop there, drive the re-run off have_initial_snapshot() instead of iterations > 0, and add a way to leave repro mode.

Related
#276, #56

Status
Reported by static code review at 79972db; not yet re-verified line by line. Found by reading the code; not reproduced under SIMICS.

主要语言
Rust
星标
335
派生
26
平均合并
1 天 50 分钟
30 天内合并 PR
12

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

intel/tsffs 的其他 Issue

查看 intel/tsffs 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。