storage 9.0.0: a custom apiEndpoint always authenticates now (useAuthWithCustomEndpoint is ignored), so emulators need credentials

未关闭
#9,873 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃

调研方向

Start in handwritten/storage and trace how Storage passes apiEndpoint and useAuthWithCustomEndpoint into StorageTransport. Read StorageTransport.makeRequest alongside resumable-upload.js, which the issue says still handles custom endpoints without authentication. Reproduce with fake-gcs-server and verify that JSON API calls work without credentials when the option is false, while authentication is used when it is true.

由索引模型根据 Issue 内容生成。

描述

Package: @google-cloud/storage (handwritten/storage)

Environment

  • @google-cloud/storage 9.0.0 (gaxios 8.3.3, google-auth-library 11.3.4)
  • Node 22.23.4 (same under Bun 1.4.4)
  • No Google credentials in the environment: no GOOGLE_APPLICATION_CREDENTIALS, no gcloud ADC, not on GCP

Steps to reproduce

Against fake-gcs-server (docker run -p 4443:4443 fsouza/fake-gcs-server -scheme http -backend memory):

import { Storage } from "@google-cloud/storage";

for (const opts of [{}, { useAuthWithCustomEndpoint: false }]) {
  const storage = new Storage({ projectId: "p", apiEndpoint: "http://127.0.0.1:4443", ...opts });
  try {
    const [exists] = await storage.bucket("repro-bucket").file("missing.txt").exists();
    console.log(opts, "exists() answered", exists);
  } catch (e) {
    console.log(opts, e.message);
  }
}

Actual (9.0.0)

{} Could not load the default credentials. Browse to https://cloud.google.com/docs/authentication/getting-started for more information.
{ useAuthWithCustomEndpoint: false } Could not load the default credentials. Browse to https://cloud.google.com/docs/authentication/getting-started for more information.

The same happens for every JSON API call (getMetadata, download, createReadStream, copy, delete, getFiles, save with resumable: false). Resumable uploads still work without credentials.

Expected (8.4.0)

{} exists() answered false
{ useAuthWithCustomEndpoint: false } exists() answered false

A custom endpoint is not authenticated unless useAuthWithCustomEndpoint is true, which is still what the option's JSDoc says in 9.0.0 ("Controls whether or not to use authentication when using a custom endpoint", default false).

Cause

Storage still sets customEndpoint and passes useAuthWithCustomEndpoint to StorageTransport, which stores it but never reads it: makeRequest sends every request through this.authClient.request() (a GoogleAuth), so credentials are looked up whatever the endpoint. resumable-upload.js still checks useAuthWithCustomEndpoint and uses plain gaxios for a custom endpoint, which is why resumable uploads keep working. MIGRATION.md doesn't mention the change.

Workaround

new Storage({ apiEndpoint, authClient: new PassThroughClient() }), with PassThroughClient from google-auth-library.

Suggested fix

In StorageTransport.makeRequest, send the request without authentication when the endpoint is custom and useAuthWithCustomEndpoint is not true, as 8.x did (for example through the plain gaxios instance, as resumable-upload.js does).

主要语言
TypeScript
星标
3.2k
派生
732
平均合并
2 天 11 小时
30 天内合并 PR
99

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

googleapis/google-cloud-node 的其他 Issue

查看 googleapis/google-cloud-node 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。