storage 9.0.0: a custom apiEndpoint always authenticates now (useAuthWithCustomEndpoint is ignored), so emulators need credentials
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 72/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- node.js, typescript
- Área
- authentication, backend
Línea de trabajo
Start in handwritten/storage and trace how Storage passes apiEndpoint and useAuthWithCustomEndpoint into StorageTransport. Read StorageTransport.makeRequest alongside resumable-upload.js, which the issue says still handles custom endpoints without authentication. Reproduce with fake-gcs-server and verify that JSON API calls work without credentials when the option is false, while authentication is used when it is true.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Package: @google-cloud/storage (handwritten/storage)
Environment
@google-cloud/storage9.0.0 (gaxios 8.3.3, google-auth-library 11.3.4)- Node 22.23.4 (same under Bun 1.4.4)
- No Google credentials in the environment: no
GOOGLE_APPLICATION_CREDENTIALS, no gcloud ADC, not on GCP
Steps to reproduce
Against fake-gcs-server (docker run -p 4443:4443 fsouza/fake-gcs-server -scheme http -backend memory):
import { Storage } from "@google-cloud/storage";
for (const opts of [{}, { useAuthWithCustomEndpoint: false }]) {
const storage = new Storage({ projectId: "p", apiEndpoint: "http://127.0.0.1:4443", ...opts });
try {
const [exists] = await storage.bucket("repro-bucket").file("missing.txt").exists();
console.log(opts, "exists() answered", exists);
} catch (e) {
console.log(opts, e.message);
}
}
Actual (9.0.0)
{} Could not load the default credentials. Browse to https://cloud.google.com/docs/authentication/getting-started for more information.
{ useAuthWithCustomEndpoint: false } Could not load the default credentials. Browse to https://cloud.google.com/docs/authentication/getting-started for more information.
The same happens for every JSON API call (getMetadata, download, createReadStream, copy, delete, getFiles, save with resumable: false). Resumable uploads still work without credentials.
Expected (8.4.0)
{} exists() answered false
{ useAuthWithCustomEndpoint: false } exists() answered false
A custom endpoint is not authenticated unless useAuthWithCustomEndpoint is true, which is still what the option's JSDoc says in 9.0.0 ("Controls whether or not to use authentication when using a custom endpoint", default false).
Cause
Storage still sets customEndpoint and passes useAuthWithCustomEndpoint to StorageTransport, which stores it but never reads it: makeRequest sends every request through this.authClient.request() (a GoogleAuth), so credentials are looked up whatever the endpoint. resumable-upload.js still checks useAuthWithCustomEndpoint and uses plain gaxios for a custom endpoint, which is why resumable uploads keep working. MIGRATION.md doesn't mention the change.
Workaround
new Storage({ apiEndpoint, authClient: new PassThroughClient() }), with PassThroughClient from google-auth-library.
Suggested fix
In StorageTransport.makeRequest, send the request without authentication when the endpoint is custom and useAuthWithCustomEndpoint is not true, as 8.x did (for example through the plain gaxios instance, as resumable-upload.js does).
- Lenguaje dominante
- TypeScript
- Estrellas
- 3.2k
- Forks
- 732
- Merge medio
- 2 d 11 h
- PR fusionados (30 d)
- 99
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de googleapis/google-cloud-node
-
Broken deprecation chainAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
googleapis/google-cloud-node#9854 ·
Los mantenedores suelen responder en 1 día
-
pubsub: "Operation attempted on ended Span" when a modack is flushed after the message was ackedAbiertoapi: pubsub
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
googleapis/google-cloud-node#9853 ·
Los mantenedores suelen responder en 1 día
-
storage: V4 getSignedUrl sorts canonical headers with localeCompare, so they disagree with X-Goog-SignedHeadersPosiblemente ocupada @itsrayeedscodespace la tomó hace 9 días. Abiertoapi: storage
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
googleapis/google-cloud-node#9840 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
firestore: getPartitions() emits gax AutopaginateTrueWarning in every processPosiblemente ocupada @TheRealDanii la tomó hace 12 días. Abiertoapi: firestore
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
googleapis/google-cloud-node#9736 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
googleapis/google-cloud-node#9723 ·
Los mantenedores suelen responder en 1 día
Todos los issues de googleapis/google-cloud-node
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
oxc-project/tsrs#1010 ·
Los mantenedores suelen responder en 1 día
-
area:infra area:storage bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
THU-MAIC/OpenMAIC#2311 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
docs documentation need-triage SaaS
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
enhancement from-app needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
nightly-labs/openbot#10973 ·
Los mantenedores suelen responder en 1 día
-
status/need-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
google-gemini/gemini-cli#30328 · 1 comentario ·
Los mantenedores suelen responder en 1 día