storage 9.0.0: a custom apiEndpoint always authenticates now (useAuthWithCustomEndpoint is ignored), so emulators need credentials

Abierto
#9,873 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
node.js, typescript

Línea de trabajo

Start in handwritten/storage and trace how Storage passes apiEndpoint and useAuthWithCustomEndpoint into StorageTransport. Read StorageTransport.makeRequest alongside resumable-upload.js, which the issue says still handles custom endpoints without authentication. Reproduce with fake-gcs-server and verify that JSON API calls work without credentials when the option is false, while authentication is used when it is true.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Package: @google-cloud/storage (handwritten/storage)

Environment

  • @google-cloud/storage 9.0.0 (gaxios 8.3.3, google-auth-library 11.3.4)
  • Node 22.23.4 (same under Bun 1.4.4)
  • No Google credentials in the environment: no GOOGLE_APPLICATION_CREDENTIALS, no gcloud ADC, not on GCP

Steps to reproduce

Against fake-gcs-server (docker run -p 4443:4443 fsouza/fake-gcs-server -scheme http -backend memory):

import { Storage } from "@google-cloud/storage";

for (const opts of [{}, { useAuthWithCustomEndpoint: false }]) {
  const storage = new Storage({ projectId: "p", apiEndpoint: "http://127.0.0.1:4443", ...opts });
  try {
    const [exists] = await storage.bucket("repro-bucket").file("missing.txt").exists();
    console.log(opts, "exists() answered", exists);
  } catch (e) {
    console.log(opts, e.message);
  }
}

Actual (9.0.0)

{} Could not load the default credentials. Browse to https://cloud.google.com/docs/authentication/getting-started for more information.
{ useAuthWithCustomEndpoint: false } Could not load the default credentials. Browse to https://cloud.google.com/docs/authentication/getting-started for more information.

The same happens for every JSON API call (getMetadata, download, createReadStream, copy, delete, getFiles, save with resumable: false). Resumable uploads still work without credentials.

Expected (8.4.0)

{} exists() answered false
{ useAuthWithCustomEndpoint: false } exists() answered false

A custom endpoint is not authenticated unless useAuthWithCustomEndpoint is true, which is still what the option's JSDoc says in 9.0.0 ("Controls whether or not to use authentication when using a custom endpoint", default false).

Cause

Storage still sets customEndpoint and passes useAuthWithCustomEndpoint to StorageTransport, which stores it but never reads it: makeRequest sends every request through this.authClient.request() (a GoogleAuth), so credentials are looked up whatever the endpoint. resumable-upload.js still checks useAuthWithCustomEndpoint and uses plain gaxios for a custom endpoint, which is why resumable uploads keep working. MIGRATION.md doesn't mention the change.

Workaround

new Storage({ apiEndpoint, authClient: new PassThroughClient() }), with PassThroughClient from google-auth-library.

Suggested fix

In StorageTransport.makeRequest, send the request without authentication when the endpoint is custom and useAuthWithCustomEndpoint is not true, as 8.x did (for example through the plain gaxios instance, as resumable-upload.js does).

Lenguaje dominante
TypeScript
Estrellas
3.2k
Forks
732
Merge medio
2 d 11 h
PR fusionados (30 d)
99

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de googleapis/google-cloud-node

Todos los issues de googleapis/google-cloud-node

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.