[Feature]: Skill resources for presets (copy-mode aware composition and preset-owned resources)

未关闭
#5,382 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
tooling

调研方向

Start with presets/_resolver.py at PresetResolver.resolve_content and compare its path rewriting with the copy-mode handling from #5366. Then read extensions/_skill_resources.py and the extension resource lifecycle tests to trace validation, copying, registry ownership, and removal. Done means the acceptance criteria define stacked resource ownership and preset removal behavior, with matching tests for composition and resource lifecycle.

由索引模型根据 Issue 内容生成。

描述

triage-can-wait

Problem Statement

#5366 lets extension commands declare resources that are copied into their generated agent skills ("copy mode"; skill bodies are not path-rewritten). Presets are not covered:

  1. Composition: when a preset overrides a copy-mode extension command with append/prepend/wrap, PresetResolver.resolve_content (presets/_resolver.py ~l.789) still applies rewrite_extension_paths to the extension base layer. The composed skill therefore references .specify/extensions/<id>/... instead of the copied skill-relative resources. It still resolves, but is inconsistent with copy mode.
  2. Preset-owned resources: presets that override or provide skills cannot bundle their own resources (references, templates, scripts) into the skill directory.

Proposed Solution

  • Make preset composition copy-mode aware for skill outputs: when the winning base layer is a copy-mode extension command and the output is a skill, do not rewrite its paths. Command/template consumers keep today's rewriting.
  • Add an optional resources list to preset command/template entries in preset.yml (same pattern dialect as extension resources), copied into the preset's skill output with hash-tracked ownership in the preset registry, reusing the extension resource helper (extensions/_skill_resources.py).

Alternatives Considered

  • Keep presets on extension-local paths only (today's behaviour): works, but preset authors cannot ship skill-relative files.
  • Only fix composition (item 1) and defer preset-owned resources.

Component

Presets / skills rendering

AI Agent (if applicable)

All SKILL.md-based integrations

Use Cases

  • A team preset appends review rules to an extension skill and ships its own references/team-rules.md.
  • A preset wraps a copy-mode extension command and the composed skill should keep skill-relative references.

Acceptance Criteria

  • Composed skill bodies over a copy-mode extension base are not path-rewritten; non-skill outputs unchanged.
  • Preset resources are validated like extension resources and copied as regular files.
  • Ownership defined for path conflicts between an extension and one or more presets writing the same skill directory (who wins, who owns, what happens on preset removal and priority changes).
  • Defined behaviour for stacked layers (append/prepend/wrap): whose resources are copied.
  • On preset remove, preset-owned resources are removed and the extension's resources/skill are restored.
  • Tests mirror the extension resource lifecycle tests.

Additional Context

Deferred out of #5366 by design; that change only restores extension copy-mode skills (with resources) after preset remove.

AI Disclosure

Drafted with the pi coding agent (orchestrator model: Claude Opus 5.5 via GitHub Copilot; implementation/review subagents: GPT-6.1-terra, GPT-6-astra), human-supervised by the filer. Reproductions were run locally by the agent and reviewed by the filer before filing.

主要语言
Python
星标
149k
派生
13.4k
平均合并
1 天 5 小时
30 天内合并 PR
223

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

github/spec-kit 的其他 Issue

查看 github/spec-kit 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。