[Feature]: Skill resources for presets (copy-mode aware composition and preset-owned resources)

Aperta
  • Qualcosa non va?
#5,382 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
tooling

Direzione di ricerca

Start with presets/_resolver.py at PresetResolver.resolve_content and compare its path rewriting with the copy-mode handling from #5366. Then read extensions/_skill_resources.py and the extension resource lifecycle tests to trace validation, copying, registry ownership, and removal. Done means the acceptance criteria define stacked resource ownership and preset removal behavior, with matching tests for composition and resource lifecycle.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

triage-can-wait

Problem Statement

#5366 lets extension commands declare resources that are copied into their generated agent skills ("copy mode"; skill bodies are not path-rewritten). Presets are not covered:

  1. Composition: when a preset overrides a copy-mode extension command with append/prepend/wrap, PresetResolver.resolve_content (presets/_resolver.py ~l.789) still applies rewrite_extension_paths to the extension base layer. The composed skill therefore references .specify/extensions/<id>/... instead of the copied skill-relative resources. It still resolves, but is inconsistent with copy mode.
  2. Preset-owned resources: presets that override or provide skills cannot bundle their own resources (references, templates, scripts) into the skill directory.

Proposed Solution

  • Make preset composition copy-mode aware for skill outputs: when the winning base layer is a copy-mode extension command and the output is a skill, do not rewrite its paths. Command/template consumers keep today's rewriting.
  • Add an optional resources list to preset command/template entries in preset.yml (same pattern dialect as extension resources), copied into the preset's skill output with hash-tracked ownership in the preset registry, reusing the extension resource helper (extensions/_skill_resources.py).

Alternatives Considered

  • Keep presets on extension-local paths only (today's behaviour): works, but preset authors cannot ship skill-relative files.
  • Only fix composition (item 1) and defer preset-owned resources.

Component

Presets / skills rendering

AI Agent (if applicable)

All SKILL.md-based integrations

Use Cases

  • A team preset appends review rules to an extension skill and ships its own references/team-rules.md.
  • A preset wraps a copy-mode extension command and the composed skill should keep skill-relative references.

Acceptance Criteria

  • Composed skill bodies over a copy-mode extension base are not path-rewritten; non-skill outputs unchanged.
  • Preset resources are validated like extension resources and copied as regular files.
  • Ownership defined for path conflicts between an extension and one or more presets writing the same skill directory (who wins, who owns, what happens on preset removal and priority changes).
  • Defined behaviour for stacked layers (append/prepend/wrap): whose resources are copied.
  • On preset remove, preset-owned resources are removed and the extension's resources/skill are restored.
  • Tests mirror the extension resource lifecycle tests.

Additional Context

Deferred out of #5366 by design; that change only restores extension copy-mode skills (with resources) after preset remove.

AI Disclosure

Drafted with the pi coding agent (orchestrator model: Claude Opus 5.5 via GitHub Copilot; implementation/review subagents: GPT-6.1-terra, GPT-6-astra), human-supervised by the filer. Reproductions were run locally by the agent and reviewed by the filer before filing.

Lingua principale
Python
Stelle
149k
Fork
13.4k
Merge medio
1g 5h
PR unite (30g)
223

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di github/spec-kit

Tutte le issue di github/spec-kit

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.